Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fix OverlayScrollbar #62

Open
jkuester opened this issue Jan 4, 2021 · 6 comments
Open

Fix OverlayScrollbar #62

jkuester opened this issue Jan 4, 2021 · 6 comments
Assignees

Comments

@jkuester
Copy link
Collaborator

jkuester commented Jan 4, 2021

Newer versions of Chrome/Electron appear to have broken the OverlayScrollbar functionality: electron/electron#14901.

For now CFD has been reverted to the default scrollbars until we can find a solution to this issue. Possibly we just need to integrate a manual css/js solution from a dependency like https://github.com/KingSora/OverlayScrollbars.

@jkuester jkuester added good first issue help wanted Extra attention is needed Severity4: Inconvenient Type: Bug Something isn't working labels Jan 4, 2021
@TobiTenno
Copy link
Member

Do we want to just hide scrollbars?

@jkuester
Copy link
Collaborator Author

jkuester commented Jan 4, 2021

I mean, I don't think we want to lose them altogether since some people might want to use them for navigating the report. It would just be nice if they could "overlay" like they used to...

@TobiTenno
Copy link
Member

yeah, i just want to avoid adding bloat for the sake of sidebars

@jkuester
Copy link
Collaborator Author

jkuester commented Jan 4, 2021

Agreed. Maybe there is still a way to do this "natively" in electron, but I have not found it yet.

@TobiTenno
Copy link
Member

Theoretically we could do the scrollbars styling manually as we do the hiding elsewhere.

@SeanHub
Copy link

SeanHub commented Oct 6, 2022

Google Chrome supports overlay scrollbars as a flag that you can enable. Electron doesn't seem to have the same support. Are overlay scrollbars going to be added in? Without them apps look a bit ugly on the eye in Windows.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants