Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[Spike] [terra-menu] - Investigate Allowing Submenu Resizing #952

Closed
StephenEsser opened this issue Oct 24, 2019 · 6 comments
Closed

[Spike] [terra-menu] - Investigate Allowing Submenu Resizing #952

StephenEsser opened this issue Oct 24, 2019 · 6 comments

Comments

@StephenEsser
Copy link
Contributor

StephenEsser commented Oct 24, 2019

Feature Request

Investigate allowing the terra-menu to resize for submenu navigation.

Description

When the menu opens the initial height of the menu establishes the static height the menu will be for the lifetime of that popup.

Teams are starting to uncover workflows where the initial main menu height is relatively small and the submenu height is much larger. We should spike on the feasibility/usability of allowing menus to resize.

@ Mentions

@jmsv6d @neilpfeiffer

@lokesh-0813
Copy link
Contributor

@StephenEsser Are we looking at exposing a prop to set the height of the menu? Or we could reset the menu height based on subMenu items(My initial opinion and still need to dig more). Any thoughts on this?

@StephenEsser
Copy link
Contributor Author

StephenEsser commented Nov 14, 2019

@lokesh-0813

When logging this issue originally I was thinking something similar to a prop that sets an auto dynamic height of the menu as necessary. Similar to the terra-popop auto height API.

This request came through from a UX designer and a few other teams. We should get more confirmation about the expected functionality.

cc: @neilpfeiffer @jmsv6d

@jmsv6d
Copy link
Contributor

jmsv6d commented Nov 14, 2019

Currently the menu will auto size the height based on the height of the main menu, but maintains that height for submenus. There is code in the menu right now that forces this to happen. If the submenu is smaller than the main menu, this is fine, but there are some scenarios where the submenu is longer than the main menu and the user may end up with a small popup with a scrollbar. I was thinking we have a couple of options (we could pick one or do both)

  1. Bool prop that allows for dynamic sizing of submenus. The downside to this approach is that resizing of menu could cause the popup to need to be repositioned, causing a jarring user experience.
  2. Open up the prop with all the popup menu sizing options. Then consumers could pick the set height for the menu, users wouldn't have the potentially jarring experience of the popup resizing during menu navigation and they could choose a size that would be more appropriate for all the menu's "pages".
    But I think we need input from @neilpfeiffer on what approach we want to take and if we want to make a change at all.

@stale
Copy link

stale bot commented Oct 4, 2021

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed in seven days if no further activity occurs. Thank you for your contributions.

@neilpfeiffer
Copy link
Member

Should also pair with a fix missing headers and text wrapping/flexing header height:
#474

Changes needed were discussed during the UX Audit:
#1297

@neilpfeiffer neilpfeiffer reopened this Jun 10, 2022
@stale stale bot removed the inactive label Jun 10, 2022
@stale
Copy link

stale bot commented Aug 9, 2022

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed in seven days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactive label Aug 9, 2022
@stale stale bot closed this as completed Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.