Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display description if there's no image #35

Open
chaosbastler opened this issue May 27, 2014 · 3 comments
Open

Display description if there's no image #35

chaosbastler opened this issue May 27, 2014 · 3 comments

Comments

@chaosbastler
Copy link
Owner

The app should display the description of the exercise when there is no image but an description.

@christopherfowers
Copy link

Some of these descriptions seem rather short and non-descriptive. For example Arnold Shoulder Press. Is this something that I should still use or was there another one that I should be focused on? Also, is there a preferred font and font size?

@chaosbastler
Copy link
Owner Author

I had a look at the Arnold Shoulder Press - it has a link to a youtube video. Making this link clickable (start an Intent) would make the description usefull again.
Of course pictures would be much better. But displaying a bad description is often better than displaying nothing at all.

About font and size: just use the default values that android provides. If it seems too small feel free to change the size as you like.

@christopherfowers
Copy link

Pull request up

Sent from my Verizon 4G LTE Smartphone

----- Reply message -----
From: "Christian Skubich" [email protected]
To: "chaosbastler/opentraining" [email protected]
Cc: "christopherfowers" [email protected]
Subject: [opentraining] Display description if there's no image (#35)
Date: Fri, Feb 27, 2015 1:58 PM

I had a look at the Arnold Shoulder Press - it has a link to a youtube video. Making this link clickable (start an Intent) would make the description usefull again.

Of course pictures would be much better. But displaying a bad description is often better than displaying nothing at all.

About font and size: just use the default values that android provides. If it seems too small feel free to change the size as you like.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants