Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest version of rest-client (why a downgrade!?) #55

Open
collimarco opened this issue Jun 24, 2021 · 13 comments
Open

Use the latest version of rest-client (why a downgrade!?) #55

collimarco opened this issue Jun 24, 2021 · 13 comments
Labels
feature Planned to release on next major version

Comments

@collimarco
Copy link

Hello,

Why is there a downgrade of the rest-client gem? Your commit message is empty...

Please clarify the motivation and fix this in order to use the latest version. It is important to use always the latest gem version to avoid bugs and security issues.

@cb-rakesh
Copy link

The deprecation has been done to support backward compatibility. We are working on upgrading to the latest version of rest-client in the further releases.

@ActualAl
Copy link

Hi there is there any news on this? It's preventing upgrades to other critical gems that require rest_client >= 2.1

@cb-khushbubibay cb-khushbubibay added the feature Planned to release on next major version label Jun 13, 2023
@jfloff
Copy link

jfloff commented Jan 19, 2024

Any updates on this?

@callahat
Copy link

callahat commented Apr 3, 2024

Bump

@DevStarks
Copy link

Any updates on this? @cb-khushbubibay @cb-rakesh

@loomchild
Copy link

@cb-alish Could you please look into this and clarify why the old version of rest-client is needed (sorry to mentioning you directly, but you seem to be the last person who committed to this repo).

@cb-alish
Copy link
Collaborator

Hi @loomchild, It seems to have some compatibility issues. Specifically, the rest_client version 2.1.0 includes breaking changes. Please refer to #43 & #50 once.

@loomchild
Copy link

loomchild commented Aug 27, 2024

Ah, it makes sense, thank you very much for the information. I will investigate what to do (since I also have a conflict with another gem requiring 2.1.0).

@loomchild
Copy link

@cb-alish The breaking change seems to be located in rest-client/rest-client#597 and there's a workaround described in rest-client/rest-client#740 (comment). Would you consider implementing it (looks like the change is located only in rest.rb file).

If not, would you potentially accept a PR implementing it? (I would need help in testing the use cases reported in PRs you linked, but can give it a try).

@cb-alish
Copy link
Collaborator

cb-alish commented Sep 4, 2024

Hi @loomchild, sure we'll consider implementing it but it might take a few weeks before we can get to this.

If you'd like to contribute, please create a PR and we can definitely test & include it in the SDK.

@loomchild
Copy link

loomchild commented Sep 8, 2024

I had some ideas what could be the issue and how to solve it based on rest-client/rest-client#722. But when I have simply tried to bump rest-client to 2.1.0, I was able to retrieve a subscription via (as described in #43):

ChargeBee::Subscription.retrieve(subscription_id).subscription

Could you clarify how to reproduce the issues described in #43 and #50? Do I perhaps need to use a specific version of Ruby? (I tested with 3.3.4 and 2.7.8) Maybe Net::HTTP has evolved so the issues no longer occur?

@cb-alish
Copy link
Collaborator

cb-alish commented Nov 5, 2024

Hi @callahat & @DevStarks could you take a look at #85 when you have a moment? We're transitioning to Net::HTTP with the goal of removing rest-client as a dependency. Just want to make sure everything looks good from your side. Thanks!

@cb-alish
Copy link
Collaborator

Hi @callahat & @DevStarks! We've released the beta version of the library, now using Net::HTTP and removing rest-client as a dependency. Could you give it a spin in your test environments and share any feedback? Thanks! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Planned to release on next major version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants