Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure consistent and responsive course card heights on /courses page #1262

Open
2 tasks
kyleecodes opened this issue Jan 13, 2025 · 13 comments · May be fixed by #1337
Open
2 tasks

Ensure consistent and responsive course card heights on /courses page #1262

kyleecodes opened this issue Jan 13, 2025 · 13 comments · May be fixed by #1337
Assignees
Labels
complexity: beginner Time needed to do this ticket is less than 1 day. first-timers-friendly Appropriate for first time contributors. frontend good-first-issue Good for newcomers help wanted Extra attention is needed UX User experience design web-development
Milestone

Comments

@kyleecodes
Copy link
Member

Overview

All course cards displayed on the '/courses' page must have a consistent height. Currently, the varying lengths of course card titles are causing unintended height differences in the UI (see attached image for reference). The course card heights should remain uniform across the page while ensuring responsiveness across all devices.

Action Items

  • Configure the course card heights on '/courses' page to be the same height.
  • Check that course card heights are consistent and responsive on different devices (mobile, browser, tablet, etc).

Resources

Image
@kyleecodes kyleecodes added complexity: beginner Time needed to do this ticket is less than 1 day. first-timers-friendly Appropriate for first time contributors. frontend good-first-issue Good for newcomers help wanted Extra attention is needed UX User experience design web-development labels Jan 13, 2025
@kyleecodes kyleecodes added this to the 02. Roadmaps milestone Jan 13, 2025
@maniac-tech
Copy link

No one has been assigned the issue yet, is this up for grabs ?

Copy link
Contributor

Thank you @maniac-tech you have been assigned this issue!
Please follow the directions in our Contributing Guide. We look forward to reviewing your pull request. ✨


Support Chayn's mission? ⭐ Please star this repo to help us find more contributors like you!
Learn more about Chayn's impact here. 🌸

@Rafacv23
Copy link

I can do it

@kyleecodes
Copy link
Member Author

@maniac-tech any updates on this issue?

@Rafacv23 thanks for your interest! If there are no updates from the current assignee within 1 week, this issue will be marked "stale" and open for new assignees. We can ping you to be re-assigned then.

@OfficialSubham
Copy link

Can i work on this??

Copy link
Contributor

Thank you @OfficialSubham you have been assigned this issue!
Please follow the directions in our Contributing Guide. We look forward to reviewing your pull request. ✨


Support Chayn's mission? ⭐ Please star this repo to help us find more contributors like you!
Learn more about Chayn's impact here. 🌸

@OfficialSubham
Copy link

hey please assign it to someone else because i cannot do this as there is no documentation in your github on how to start your app. You guys should make one then it will be very good for beginners

@Shrihari10
Copy link

Hey @kyleecodes, I believe I can fix this. I am pretty new to open source, so I would like to give this a shot since the current assignee has asked this to be reassigned. Thanks in Advance

Copy link
Contributor

Thank you @Shrihari10 you have been assigned this issue!
Please follow the directions in our Contributing Guide. We look forward to reviewing your pull request. ✨


Support Chayn's mission? ⭐ Please star this repo to help us find more contributors like you!
Learn more about Chayn's impact here. 🌸

@Shrihari10
Copy link

Hey @kyleecodes, I've got both the frontend and the backend running. I would like to understand what solution is expected. From what I see, we have 3 - 4 approaches to solve this,

  1. Convert 2 columns to 1 column below 800 pixels like mobile screens (Straight forward)

  2. Introduce word break, which adds hyphen to the broken word

  3. Hide extra characters with ......

  4. Rearrange contents inside the card such that icon comes on top and text pans the entire card width (2 rows like courses on coursera)

Please let me know what you would want me to implement, thanks!

@kyleecodes
Copy link
Member Author

@Shrihari10 great question! These are all great solutions. I would suggest a combination:

  1. Convert 2 columns to 1 for mobile screens.
  2. Implement a standard, fixed card size. Then use hyphens or hiding extra characters with "..." to help conform all cards to the same size regardless of text.

@Shrihari10
Copy link

@kyleecodes sounds good, I'll push the fix by today EOD. Thanks again!

@Shrihari10
Copy link

@kyleecodes please review the video below and the PR linked to this issue. Let me know if any further changes are required.

bloom-frontend-fix.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: beginner Time needed to do this ticket is less than 1 day. first-timers-friendly Appropriate for first time contributors. frontend good-first-issue Good for newcomers help wanted Extra attention is needed UX User experience design web-development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants