Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps]: pin git dependencies to a certain rev #34

Closed
niklasad1 opened this issue Nov 14, 2021 · 2 comments
Closed

[deps]: pin git dependencies to a certain rev #34

niklasad1 opened this issue Nov 14, 2021 · 2 comments

Comments

@niklasad1
Copy link

This should be done to ensure older versions of this library still works.

See polkascan/py-subwasm-bindings#1 for motivation for example

@chevdor
Copy link
Owner

chevdor commented Nov 15, 2021

Hi @niklasad1, I am a little confused by your statement:

The problem is that subwasm is using latest master for jsonrpsee and v0.6.0 relied on old version that had many breaking changes.

as subwasm uses:

jsonrpsee = {version = "0.4", git = "https://github.com/paritytech/jsonrpsee", features = ["full"]}

and its cargo.lock has jsonrpsee pinned to:

version = "0.4.1"
source = "git+https://github.com/paritytech/jsonrpsee#ff3337b107bf29bef6067164c20c6a0b0b5bdc75"

The dependency on jsonrpsee master was likely true in the past though.

So it sounds like py-subwasm should upgrade its deps but do you see anything to be done the suwbasm side ?

@niklasad1
Copy link
Author

Ah, I think I got confused by that you use both git and version in Cargo.toml

nvm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants