Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuned data panel tabs content alignment to have more consistent UI #250

Merged
merged 1 commit into from
Jan 10, 2021

Conversation

xnike
Copy link
Contributor

@xnike xnike commented Jan 8, 2021

I've made a small tunings for UI:

  • tabs are on the same level for chart and data panels
  • margins between labels on data panel are now the same on chart and data panels

Before:
before

After:
after

@codecov-io
Copy link

codecov-io commented Jan 8, 2021

Codecov Report

Merging #250 (cea47f6) into develop (399d713) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #250      +/-   ##
=============================================
- Coverage      70.34%   70.33%   -0.01%     
  Complexity      1519     1519              
=============================================
  Files            146      146              
  Lines           8638     8644       +6     
  Branches        1395     1396       +1     
=============================================
+ Hits            6076     6080       +4     
- Misses          1973     1976       +3     
+ Partials         589      588       -1     
Impacted Files Coverage Δ Complexity Δ
...va/com/tagtraum/perf/gcviewer/view/GCDocument.java 33.97% <100.00%> (ø) 23.00 <0.00> (ø)
...tagtraum/perf/gcviewer/view/ModelMetricsPanel.java 96.00% <100.00%> (+0.06%) 5.00 <0.00> (ø)
...gtraum/perf/gcviewer/ctrl/impl/GcSeriesLoader.java 74.15% <0.00%> (-2.25%) 19.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 399d713...cea47f6. Read the comment docs.

@chewiebug chewiebug merged commit b6a75a7 into chewiebug:develop Jan 10, 2021
@chewiebug
Copy link
Owner

chewiebug commented Jan 10, 2021 via email

@chewiebug chewiebug added this to the 1.37 milestone Jan 10, 2021
@xnike xnike deleted the data-panel-ui-filling branch January 10, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants