Downloading multiple images has become much slower

[selwun]

Not really a bug per se, but on the current main site, all downloads open a new empty tab, which process the download and allow the user to start another download right away.

However, on the current beta site, the downloads are processed within the preview page, which seems to make it impossible to start multiple downloads of the same card at once, and in general makes downloading multiple images at once more tedious.

Hope this makes sense enough. I'm using Edge Version 117.0.2045.41 64-Bit on Windows 11.

[ndepaola]

g'day! the motivation for reworking the frontend's download functionality is that a) opening a new tab to download an image is a crappy user experience imo, and b) you will get rate-limited by google drive very quickly if you attempt to download many images.

there's a dedicated menu for downloading multiple images which you can access by selecting the cards you want to download the images for, then clicking Download -> Card Images. image downloads here are multi-threaded so they shouldn't be too slow hopefully.

it sounds like you were downloading many images one by one in the detailed view modal rather than through the bulk downloader - is that correct? if so, does the bulk downloader address your concerns?

[selwun]

Thanks for your detailed reply! The bulk downloader does seem to work well.

The only scenario that it doesn't address is the following, which I do somewhat regularly. That is for example, I search for all 10 original Duals, so I have 10 different search results. But then I want to download multiple versions of each one, that's why I used the modal detail view before. I would open it, click download, a new tab would open which deals with the download (rate-limits don't bother me much there, as the tab would just stay open until the download is finished, so I could immediately continue navigating in my main tab without worrying about that download for the moment) and I could continue browsing to other versions of the same card. I'm not sure what the best solution for that scenario would be, but the beta version doesn't really seem to account for it.

[ndepaola]

thanks for explaining your workflow, that makes sense - you're right that the new frontend doesn't really support this, but it might be possible to introduce a download queue system that's shared between the single & bulk download interfaces, so you'd be able to queue up multiple downloads in quick succession. will give this some more thought

[selwun]

ohh! something like that would be really cool :)

[ndepaola]

thanks for explaining your workflow, that makes sense - you're right that the new frontend doesn't really support this, but it might be possible to introduce a download queue system that's shared between the single & bulk download interfaces, so you'd be able to queue up multiple downloads in quick succession. will give this some more thought

i ended up implementing the shared download queue between downloading single images & downloading all images :)

[selwun]

Thanks so much, that's really cool ! I did test it and I do have the issue at the moment that the images sometimes just don't download. Everything looks fine and some do download, but other's just don't do anything even tho it looks like it should. Thanks!

…

On Sat, Jan 13, 2024 at 1:52 AM Nicholas de Paola ***@***.***> wrote: thanks for explaining your workflow, that makes sense - you're right that the new frontend doesn't really support this, but it might be possible to introduce a download queue system that's shared between the single & bulk download interfaces, so you'd be able to queue up multiple downloads in quick succession. will give this some more thought i ended up implementing the shared download queue between downloading single images & downloading all images :) — Reply to this email directly, view it on GitHub <#182 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AL34BHUBDSHF6AKDXGQF2ILYOHLE7AVCNFSM6AAAAAA5GSRSMCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJQGIYDQMJTGU> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[ndepaola]

copy that - thanks for raising this issue, i'll reopen this and look into why some images fail to download, aiming to provide better feedback to the user when this happens