Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement request for desktop-tool: Cache bust downloaded card images when image binary changes in Google Drive #207

Open
2 of 3 tasks
davidianstyle opened this issue Jan 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@davidianstyle
Copy link
Contributor

davidianstyle commented Jan 23, 2024

System

  • Operating System (including version): MacOS Sonoma 14.2.1
  • Desktop Tool Version: 87a1305
  • Browser (including version): Chrome Version 120.0.6099.234

Affected Components

  • Backend
  • Frontend
  • Desktop Tool

Description

The desktop tool seems to skip downloading files when the local desktop-tool/cards/ directory contains an image with the same name / Google Drive ID. While this is a nice performance boost, it would be nice to be able to cache bust and trigger a re-download if the binary has changed remotely.

Steps to Reproduce

  • As a proxy "creator", run the desktop-tool on an existing XML file containing a proxy you've created triggering a download to the desktop-tool/cards/ directory
  • Upload a new version of the proxy to your Google Drive with the same name/location (it should prompt you to choose between "Replace existing file" or "Keep both files")
  • Select "Replace existing file"
  • Run update_database tool to re-index cards on your backend server
  • Using your XML file in the mpcautofill.github.io tool should now show the newer version of your proxy
  • Run the desktop-tool again and notice that the tool doesn't re-download the newer version of the proxy but instead uses the already downloaded version in desktop-tool/cards/ directory
@ndepaola ndepaola added the enhancement New feature or request label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants