Refactored and fixed the frontend test that was failing.

[Mortuie]

• Refactored the action tests into one file.
• Made all frontend tests pass

[nikrb]

backend test is failing for me, has mongo version changed in package.json or something?

the options [useNewUrlParser] is not supported

and then :

  4 passing (473ms)
  2 failing

  1) User model
       insert
         should register a new user:
     TypeError: Cannot read property '_id' of null
      at Context.it (models/user/user.unit.spec.js:43:23)
      at <anonymous>
      at process._tickCallback (internal/process/next_tick.js:188:7)

  2) User model
       insert
         should reject duplicate email on registration:
     TypeError: Cannot read property '_id' of null
      at Context.it (models/user/user.unit.spec.js:58:24)
      at <anonymous>
      at process._tickCallback (internal/process/next_tick.js:188:7)

Would you rather keep that as a separate issue/pr as it's backend ?

[Mortuie]

@nikrb separate issue yes, also the newUrlParser is the option I added yesterday to prevent the deprecation warning on the backend So it seems that that might have fucked things up. Will have to look into that! -> Make a separate issue as this is only for frontend tests and the issues aren't related. The error message points to it being a sole backend problem.

[Mortuie]

@nikrb we also get [0] (node:14100) DeprecationWarning: collection.ensureIndex is deprecated. Use createIndexes instead.

and [0] (node:14100) DeprecationWarning: collection.update is deprecated. Use updateOne, updateMany, or bulkWrite instead.

[nikrb]

LGTM

[Mortuie]

@nikrb still need approval :P

[Mortuie]

@nikrb for the backend tests, what are you running, I can't seem to find what to execute to get that output?