-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can I pass a rootNode to nanohref
?
#704
Comments
Hmm, maybe I am missing something here as I tried the following: I hacked into the choo version in my |
choo hasn't really supported being used in like a "sub application" style but it could be really good for that, so I think any feature that will help it excel in that use case would be really welcome :) The behaviour in your second post kinda looks like a bug in nanohref to me, this is the code that uses the https://github.com/choojs/nanohref/blob/80c11c4fdb1c731aad1b94f4c93b0c386b97c69c/index.js#L21-L27 So when you click something, it walks up the tree until it finds either an |
Assuming the bug in A few things that could be done that I'm not a real fan of any yet:
I think option 2 would probably be the least invasive, but it's also not really what I'd call an intuitive API. Ugh. |
Is there any input on this one as well as choojs/nanohref#13 - I'd still love to implement this in one way or the other as it's a hard requirement of what I'm working on right now. |
You can compose the dependencies quite simply to achieve this. See for example: https://github.com/graforlock/choo-detached |
I am trying to mount a choo application in an "application shell" that is provided by a static site generator.
I would expect the routing behavior to be limited to the scope of choo's application host, yet
nanohref
will try to handle all anchors being clicked.Looking at the
nanohref
docs, this behavior seems to be supported by passing a secondrootNode
argument to thenanohref
function: https://github.com/choojs/nanohref#nanohrefhandlerlocation-rootnodeLooking at how choo itself is using
nanohref
it looks like passing a second argument is not intended: https://github.com/choojs/nanohref#nanohrefhandlerlocation-rootnodeThis leads me to two questions:
nanohref
as well? In this case I have to admit I am slightly unsure how the API for this could even look like considering how there is basically zero surface area for options in choo.The text was updated successfully, but these errors were encountered: