-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Add a Github Actions workflow that builds wheels on ARM64 Mac OS. #262
build: Add a Github Actions workflow that builds wheels on ARM64 Mac OS. #262
Conversation
Oh. That's an interesting outcome. Looking at the build, it is directly building a wheel from the repository without making a source distribution first, which is not what I was expecting. These wheels should work, but they also will not match the generated sdist, which is potentially a problem. I need to learn a bit more about this. |
…rms and archs. Add a faster check_build that will just build on Mac OS ARM64 and report success or failure.
0af46b2
to
a369b48
Compare
e863743
to
b60dba6
Compare
@chrchang If opening PRs for this feels like spam and you'd like me to communicate before opening them, just let me know. I've updated this PR to add two separate github actions:
|
This is fine; thank you! |
Add a github actions workflow that will build wheels for Pgenlib python package.
I initially tried to enable Linux wheel building as well with the cibuildwheel package, but their docker-based build container doesn't work out of the box with symlinks that link outside of the python package root. I'm sure that I could work around it with some config changes, if you're interested in using Github Actions to build wheels.
Unfortunately, Mac OS runners can be pretty expensive. If you're interested in having an action that checks if Pgenlib is working on Mac, it would be possible to make a much simpler Action that would only check a single Python version.
Let me know what you think. This action would have detected the broken Pgenlib on ARM when it was first broken.