#28 Update Manifest.MF #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
chrisrueger
commented
Feb 2, 2020
chrisrueger
commented
- replaced Require-Bundle with DynamicImport-Package
- to allow janino-fragment see classes in ch.qos.logback.classic (instead of just ch.qos.logback.core): e.g. ch.qos.logback.classic.Level
- also added org.slf4j which is also required to be visible and is currently missing
- needed in OSGI environments
- see logback-janino-fragment is missing imports for ch.qos.logback.classic and slf4j qos-ch/logback-contrib#28 for details
- this also fixes the change request in janino-fragment should use DynamicImport not Require-Bundle qos-ch/logback-contrib#22
* replaced Require-Bundle with DynamicImport-Package * to allow janino-fragment see classes in ch.qos.logback.classic (instead of just ch.qos.logback.core): e.g. ch.qos.logback.classic.Level * also added org.slf4j which is also required to be visible and is currently missing * needed in OSGI environments * see qos-ch#28 for details * this also fixes the change request in qos-ch#22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.