Stop putting the session info (all channels of all participants) into… #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… each audio block, because that increases the block size of the audio stream a lot when more participants join the session. It might even increase the block size beyond the maximum frame size, which makes the audio go kaputt. Instead, send a separate package with a reduced frame rate to the other clients. This makes the peak meteres be less real time, but it saves a lot in terms of audio package size and allows us to turn on FEC again!
…eter changes to the server. Not enjoying flatbuffers enough to put all the parameters into individual flatbuffer messages, we'll be just using a string with JSON here. This is low frequency data, therefore that overhead won't matter.
…e FEC setting, that is now coupled with the Heal checkbox on the client side.
…libraries needed to build only the server on Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… each audio block, because that increases the block size of the audio stream a lot when more participants join the session. It might even increase the block size beyond the maximum frame size, which makes the audio go kaputt. Instead, send a separate package with a reduced frame rate to the other clients. This makes the peak meteres be less real time, but it saves a lot in terms of audio package size and allows us to turn on FEC again!