Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timezone option #33

Open
martinbra opened this issue Oct 17, 2020 · 5 comments
Open

Add timezone option #33

martinbra opened this issue Oct 17, 2020 · 5 comments

Comments

@martinbra
Copy link
Contributor

Created from chubin/wttr.in#56
To correctly show delta time to last and next phase, and the correct phase at the days when there's a phase change, a timezone option is needed.

@chubin
Copy link
Owner

chubin commented Oct 18, 2020

A small addition:

Timezone must specified in the standard format understandable by pytz, e.g. Europe/London,
to that this could work:

pytz.timezone(tiimezone_description)

It should return a short error message for unknown timezones

@martinbra
Copy link
Contributor Author

@chubin : What is your timezone/UTC offset? I'm at America/Sao_Paulo (UTC-03) and it looks like that pyphoon is indeed using my local time when displaying the next moon phases (well, a few minutes off comparing to this site).

>pyphoon 2020-08-20
New Moon +     
1  0:17:44     
First Quarter -
5 14:59:11     

Timezone option added to my branch with a simple display of provided timezone (or UTC by default) if you want to check error messages and/or give suggestions.
Timezone is still not being used.

@martinbra
Copy link
Contributor Author

self-reminder: take a look at negative time at http://wttr.in/moon@2020-08-19

@chubin
Copy link
Owner

chubin commented Apr 25, 2021

@martinbra Martin, I am going through old issues: do we have something to do here?

@martinbra
Copy link
Contributor Author

Yes we (I) do. I'm sorry to have left this issue frozen.
I think something is broken here (just reproduced):
image

Do you see the negative time? What could be causing it?
As for the timezone option, I know I have advanced something in my fork, but I'm not sure if I pushed everything to github. I'll have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants