From f4d790ec0a761599d4fd4312fcdb3ff545e4fbe5 Mon Sep 17 00:00:00 2001 From: Elias Rad <146735585+nnsW3@users.noreply.github.com> Date: Sat, 2 Nov 2024 18:32:20 +0200 Subject: [PATCH 1/4] Update Smart_Contract_Signatures_Encoding.md --- docs/Smart_Contract_Signatures_Encoding.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/Smart_Contract_Signatures_Encoding.md b/docs/Smart_Contract_Signatures_Encoding.md index c9ef381..f730fac 100644 --- a/docs/Smart_Contract_Signatures_Encoding.md +++ b/docs/Smart_Contract_Signatures_Encoding.md @@ -117,7 +117,7 @@ bde0b9f486b1960454e326375d0b1680243e031fd4fb3f070d9a3ef9871ccfd5 (r) ``` -Note: signature type += 32 if it's signing over the actual digest in multisig context. +Note: signature type += 32 if it's signing over the actual digest in a multisig context. The constant parts need to be sorted so that the recovered signers are sorted ascending (natural order) by address (not checksummed). From a2b6bde4f894bb6f336514edfe208025b813d740 Mon Sep 17 00:00:00 2001 From: Elias Rad <146735585+nnsW3@users.noreply.github.com> Date: Sat, 2 Nov 2024 18:33:37 +0200 Subject: [PATCH 2/4] Update README.md --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 584e8b7..8a06492 100644 --- a/README.md +++ b/README.md @@ -81,7 +81,7 @@ For running integration tests in Anvil node, run `make anvil-tests`. This runs t * Sponsor paymaster `env $(grep -v '^#' .env) npx hardhat verify --network goerli --constructor-args script/sponsor_paymaster_constructor_args.js STABLECOIN_PAYMASTER_ADDRESS` * Fallback: If the verification commands do not work for contracts deployed through the hardhat deployment scripts, you can still verify manually through etherscan's UI by submitting the standard input json. - You can find this file under `deployments/polygon/solcInputs` (you can try different blockchains but I'm unsure of results). Then submit the file that you think is the one for the contract you're trying to verify. It's a bit of guessing, but you can look at the source code to try and figure it out. You may also need to verify the proxies manually through etherscan after having verified the implementation. + You can find this file under `deployments/polygon/solcInputs` (you can try different blockchains but I'm unsure of the results). Then submit the file that you think is the one for the contract you're trying to verify. It's a bit of guessing, but you can look at the source code to try and figure it out. You may also need to verify the proxies manually through etherscan after having verified the implementation. #### MSCA 1. Set up `DEPLOYER_PRIVATE_KEY`, `RPC_URL` and `ETHERSCAN_API_KEY` in .env 2. Run `source .env` @@ -136,7 +136,7 @@ For running integration tests in Anvil node, run `make anvil-tests`. This runs t ### Deployment Metadata -The below contract deployment are based on abi and bytecode to ensure the same address across all EVM-compatible chains. The abi and bytecode for each of the contracts are available at the locations below. These files were generated from first deployments, will all fields except `abi` and `bytecode` removed. +The below contract deployment is based on abi and bytecode to ensure the same address across all EVM-compatible chains. The abi and bytecode for each of the contracts are available at the locations below. These files were generated from first deployments, will all fields except `abi` and `bytecode` be removed. | Contract Name | Location | |:------------------------:|:------------------------:| From 0aa9bd3bbd947ecc7270a3c0f98a5b40a2c559b2 Mon Sep 17 00:00:00 2001 From: Elias Rad <146735585+nnsW3@users.noreply.github.com> Date: Sat, 2 Nov 2024 18:34:43 +0200 Subject: [PATCH 3/4] Update BasePaymaster.sol --- src/paymaster/BasePaymaster.sol | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/paymaster/BasePaymaster.sol b/src/paymaster/BasePaymaster.sol index 540fe09..5d92a50 100644 --- a/src/paymaster/BasePaymaster.sol +++ b/src/paymaster/BasePaymaster.sol @@ -33,8 +33,8 @@ import {PausableUpgradeable} from "@openzeppelin/contracts-upgradeable/utils/Pau * The deposit (for paying gas fees) is separate from the stake (which is locked). * Note that this signature is NOT a replacement for the account-specific signature: * - the paymaster checks a signature to agree to pay for gas. - * - the account checks a signature prove identity and account ownership. - * Since this contract is upgradable, we do not allow use either selfdestruct or delegatecall to prevent a malicious + * - the account checks a signature to prove identity and account ownership. + * Since this contract is upgradable, we do not allow the use of either selfdestruct or delegatecall to prevent a malicious * actor from * destroying the logic contract. */ From dfd9145b99e81f6793b1c6691e4d44574957c9ac Mon Sep 17 00:00:00 2001 From: Elias Rad <146735585+nnsW3@users.noreply.github.com> Date: Sat, 2 Nov 2024 18:34:58 +0200 Subject: [PATCH 4/4] Update ExecutionUtils.sol --- src/utils/ExecutionUtils.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/utils/ExecutionUtils.sol b/src/utils/ExecutionUtils.sol index 1ccd934..d4103cf 100644 --- a/src/utils/ExecutionUtils.sol +++ b/src/utils/ExecutionUtils.sol @@ -21,7 +21,7 @@ pragma solidity 0.8.24; // solhint-disable no-inline-assembly /** - * Utility functions helpful when making different kinds of contract calls in Solidity. + * Utility functions are helpful when making different kinds of contract calls in Solidity. * For inline assembly, please refer to https://docs.soliditylang.org/en/latest/assembly.html * For opcodes, please refer to https://ethereum.org/en/developers/docs/evm/opcodes/ and https://www.evm.codes/ */