Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E-mails - localisation with Crowdin #41

Closed
4 tasks done
tiblu opened this issue Nov 14, 2018 · 1 comment
Closed
4 tasks done

E-mails - localisation with Crowdin #41

tiblu opened this issue Nov 14, 2018 · 1 comment
Assignees
@tiblu

Comments

@tiblu
Copy link
Member

tiblu commented Nov 14, 2018 •
edited
Loading

Related to:

TODO

  • Move templates to Citizen OS API Crowdin project - https://crowdin.com/project/citizen-os-api
  • While on it, also translate Etherpad templates
  • Make sure governmentNotification.mu is NOT translated and is in ET by default.
  • E-mail testing - think how the testing should be performed? Implement. Right after running all tests I just grep "e-mail" | grep -c "ERROR" and expect 0 which means e-mail sending code worked, but I dont check the payloads that were sent. The possible problems that this kind of testing does not catch are wrong language, wrong partner, wrong template, wrong receiver, wrong subject etc.
@tiblu tiblu changed the title E-mails - localisation with Crowding E-mails - localisation with Crowdin Nov 14, 2018
@tiblu tiblu self-assigned this Nov 14, 2018
@tiblu tiblu mentioned this issue Nov 14, 2018
Closed
25 tasks
tiblu added a commit that referenced this issue Nov 14, 2018
@tiblu
Email localisation using Crowdin - #41
d2fd6e4
tiblu added a commit that referenced this issue Nov 14, 2018
@tiblu
Email localisation using Crowdin. Crowdin to treat files as HTML - #41
3faaa44
tiblu added a commit that referenced this issue Nov 14, 2018
@tiblu
Email localisation using Crowdin. Crowdin to treat files as HTML - #41
675a367
tiblu added a commit that referenced this issue Nov 14, 2018
@tiblu
Email localisation using Crowdin. Crowdin to treat files as HTML - #41
5b1927f
tiblu added a commit that referenced this issue Nov 14, 2018
@tiblu
Email localisation using Crowdin. Rename all Mu templates to *.mu.htm…
6c478fe 
…l so that Crowdin would recognise them as HTML and show HTML preview - #41
tiblu added a commit that referenced this issue Nov 14, 2018
@tiblu
Email localisation using Crowdin. Rename all *.mu.html templates to *…
396532a 
….html so that Crowdin file name mapping would work- #41
tiblu added a commit that referenced this issue Nov 14, 2018
@tiblu
Email localisation using Crowdin. Use English templates as source - #41
42c687e
tiblu added a commit that referenced this issue Nov 14, 2018
@tiblu
Email & Etherpad template localisation using Crowdin. Clean up JSON f…
1065187 
…iles, leave only email subjects and reusable variables - #41
tiblu added a commit that referenced this issue Nov 14, 2018
@tiblu
Email & Etherpad template localisation using Crowdin. README.md to ma…
accc173 
…ke more sense - #41
tiblu added a commit that referenced this issue Nov 14, 2018
@tiblu
Email & Etherpad template localisation using Crowdin. Modify Etherpad…
a11b734 
… templates - #41
tiblu added a commit that referenced this issue Nov 14, 2018
@tiblu
Email & Etherpad template localisation using Crowdin. Delete old temp…
785f354 
…late files, fix Etherpad template rendering - #41
tiblu added a commit that referenced this issue Nov 14, 2018
@tiblu
Email & Etherpad template localisation using Crowdin. ESLint - #41
9676acf
tiblu added a commit that referenced this issue Nov 19, 2018
@tiblu
Rahvaalgatus.ee templates back to their original form - #41
5f3e298
tiblu added a commit that referenced this issue Nov 19, 2018
@tiblu
Email source strings CitizenOS->Citizen OS - #41
9f9310a
tiblu added a commit that referenced this issue Nov 21, 2018
@tiblu
Convert emailClient.sendAccountVerification to promises. Improve erro…
e15d73a 
…r logging of middleware/error - #41
tiblu added a commit that referenced this issue Nov 21, 2018
@tiblu
Convert emailClient.sendPasswordReset to promises. POST /api/auth/pas…
2f27206 
…sword/reset/send to fail when e-mail sending fails - #41
tiblu added a commit that referenced this issue Nov 21, 2018
@tiblu
Convert emailClient.sendGroupInvite to promises. POST /api/users/:use…
30d1894 
…rId/groups/:groupId/members/users to fail when e-mail sending fails - #41
tiblu added a commit that referenced this issue Nov 21, 2018
@tiblu
Convert emailClient.sendToParliament to promises. Rename template. PU…
f081f97 
…T /topics/:topicId to fail when Parliament e-mail sending fails - #41
tiblu added a commit that referenced this issue Nov 24, 2018
@tiblu
Change email texts on Linas request - #41
b106b7e
tiblu added a commit that referenced this issue Nov 24, 2018
@tiblu
Change email texts on Linas request - #41
7f1b654
tiblu added a commit that referenced this issue Dec 5, 2018
@tiblu
Fix error handling of sendToParliament - #41
99909aa
tiblu added a commit that referenced this issue Dec 5, 2018
@tiblu
Convert libs/email functions to promises - #41
0b8f198
tiblu added a commit that referenced this issue Dec 10, 2018
@tiblu
CHANGELOG - #41
53ea162
tiblu added a commit that referenced this issue Dec 10, 2018
@tiblu
E-mail system update for localisation with Crowdin - #41
e10ed16
@tiblu
Copy link
Member Author

tiblu commented Dec 10, 2018

The testing part - sending out emails synchronously. If the e-mail fails, automated tests start to fail as the API requests will fail.

@tiblu tiblu closed this as completed Dec 10, 2018
This was referenced Dec 18, 2018
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tiblu tiblu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tiblu