-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INVITES: When users click X on 'join topic/join group', they get a blank screen #1701
Comments
Logical to me to have this overlaying the dashboard and when closing the dialog window it keeps you there. But it's not very common behaviour to be able to move this dialog window around. And wouldn't they have already seen the content of the group before pressing that "join group" action? |
@kevincrepin Ah re the last question - no, this is for invites via URL, so they've seen absolutely nothing yet at this point, this is the first thing they see (once we've swapped it with login). For private topics, public topics, private groups and public groups - so we need to decide what they see behind the pop-up in each case, and where they are taken after clicking X :) |
What page this dialog opens up over:
I don't see a need to differentiate based on what they are invited to. It's gonna make things more complex and not sure if the value is really there? Let's say we do it in such a way that if you get an invite to a private topic, the screen behind the dialog is the private topics page. If you close now it's not like that private topic you were invited to (but didn't join because you pressed X) will be visible here. So I'm not sure if the added complexity of taking this approach actually pays off? If you press X we can assume you don't want to deal with it and then the dashboard is a better "general starting point". |
@kevincrepin I definitely see your point for private topics and groups, and think it makes sense it should be overlaid over the DB(logged in)/home(logged out), but for public ones it makes a lot of sense to me that it should be overlaid over the public topic/group. My reasons for this are:
Actually, I'm reminded now that we did decide here that we would remove the 'join' pop-up entirely for public topics, and just have it for public groups. So this solution would be a kind of compromise between the two, just for groups? In which case, the solution would be:
@kevincrepin wdyt? :) |
I feel that if the main problem to solve here is the "I don't wanna join yet, but I want to see what this is about" then I'd rather have a secondary button "view without joining" instead of making the "close window" the main flow to solve that problem. And then I would say it could still follow the logic of always opening in the dashboard :D Then we don't need to make an exception on this. |
@kevincrepin Oh nice, how much simpler that is! :D Wdyt re public topics - do we do the same thing, or stick with previous decision to not have a pop-up at all? And I guess here we need to change it to: 'To join this group' (or topic) etc |
I would here again say that unless it's a massive barrier it would be nice to have the same behaviour, so we have less exceptions and the user gets used to the behaviour pattern. Yep, I'll update the text :) |
That makes sense, let's trial it like this for now then! :) So @ilmartyrk, to summarise dev tasks for this one: When a user follows a URL share line and gets a join pop-up:
|
Noting this group issue re issues that need to be fixed first though: #1706 |
Hi! |
Apologies @ilmar!! Thanks so much for bringing this to our attention. |
What is the problem?
When you follow a URL share link to a public topic or public group, the join pop-up is over a blank page.
When you then click the 'X', if you don't want to join it, you are then left on a blank page:
Why is this a problem?
Not very helpful for users. Plus doesn't give them any idea of what they're signing up to.
Possible solution.
Related to this and this issue (which discuss the fact that new users need to see as much about what they're joining as possible to decide if they want to join), I'm thinking that for public topics and groups, the pop-up can be overlaid with the group or topic greyed out a little in the background. (As it's public anyway). Then if they click X, they are taken to that group/topic anyway, just without having joined it.
For private topics, perhaps it can be overlaid over the dashboard, so then if the click X they land on the dashboard?
I'm also thinking that it would be best if this pop-up was moveable in all cases (by clicking and dragging), so the user can move it out of the way to have a look at what's in the background, to help inform them that (hopefully) yes, they do want to join!
@kevincrepin @TiinaDUX @Lidziya-p what do you think? :)
The text was updated successfully, but these errors were encountered: