Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add participants to public topics automatically when they engage (add idea, like, vote, etc) #307

Open
ilmartyrk opened this issue Nov 7, 2023 · 17 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request estimated Issues that have dev time estimates added

Comments

@ilmartyrk
Copy link
Member

ilmartyrk commented Nov 7, 2023

Currently any user can add arguments to public topic without being a member of that topic. In our redesign designs there is a text for users that are not members "Join this topic to engage in the discussion". It got me thinking that maybe we should add this extra step that users who want to join discussion should actually become members for the topic.

Pros:

  • Users can get notifications about that topic and this topic will appear in their my topics list. Better overview for the owner of the topic about who are engaging their topic.
  • Users can still always leave the topic if they wish
  • Users will have to take a thinking moment before posting any arguments this can possibly avoid some spamming
    Cons:
  • Users will have to take an extra step to join
  • For some topics user might be afraid to join to add their arguments
@ilmartyrk ilmartyrk added the enhancement New feature or request label Nov 7, 2023
@anettlinno
Copy link
Collaborator

Triage 93. This needs more discussion. Sending it to In Prep.

@ilmartyrk
Copy link
Member Author

@kevincrepin @BeccaMelhuish check if the issue is relevant or not.

@kevincrepin
Copy link
Collaborator

How I saw this was that there are two ways to "join" a topic:

  1. You can join via the join button, which means this topic is now part of your feed and notifications but you didn't have to actively interact with it – you didn't have to join discussion or share ideas etc.
  2. you can post an argument, leave a reply, share an idea or vote and this will automatically make you join the topic.

So I didn't see this so that the user would not be able to interact with the topic without joining it. Interacting includes joining.
At least that's how I saw it :)

@BeccaMelhuish
Copy link
Contributor

BeccaMelhuish commented Oct 2, 2024

@kevincrepin totally agree - this makes a lot of sense to me. Anyone who has posted should be automatically turned into a participant, can't see any reason not to (or any reason to force them to actively click 'join' before they're allowed to post) :)

Will tag @ssin1901 though in case she sees something I'm missing :)

Will also move this to soon as it does seem relevant to fix soon-ish

@BeccaMelhuish BeccaMelhuish moved this from Backlog - Later to Backlog - soon in Citizen OS GitHub issue priorities Oct 2, 2024
@BeccaMelhuish
Copy link
Contributor

BeccaMelhuish commented Oct 16, 2024

An example of this causing potential confusion/user issues in practice came to light with this one so I'll move it to 'Next?'.

An umbrella organisation set their GA voting topic to public. As not everyone joined via a join link (presumably), they have more people having voted than they have registered participants:

image

Anyone who votes should be automatically added as a participant, same as adding any other contribution (argument / idea / reply / reaction)

@BeccaMelhuish BeccaMelhuish added the bug Something isn't working label Oct 16, 2024
@BeccaMelhuish BeccaMelhuish moved this from Backlog - soon to Backlog - next? in Citizen OS GitHub issue priorities Oct 16, 2024
@BeccaMelhuish BeccaMelhuish changed the title User should be a member of the topic to add arguments Add participants to public topics automatically when they engage (add idea, like, vote, etc) Oct 25, 2024
@ilmartyrk
Copy link
Member Author

ilmartyrk commented Nov 8, 2024

Okay, estimated dev time is 3h, will add the users as participants to the topic when posting idea, argument/reply or casting their vote.

My question is should we also do backward migration so that historic data would also change? This would take at least 8h to create a script that takes all the users that have done these actions in the past and are not members of the topics

@BeccaMelhuish
Copy link
Contributor

BeccaMelhuish commented Nov 8, 2024

@ilmartyrk Wonderful. Should we also add them if they react too? (I.e. like an idea or argument or reply).

Re historic data, that's a good question. My general feeling is that we haven't had enough really active public topics in the past for it to be worthwhile, and also it's unlikely that old public topics are getting looked at much.

But.. there are some currently or recently active public topics for which it would be great to have the correct participant numbers showing (IOF for example, plus some DD Foundation ones for which the issue might possibly be relevant). If we were to select a small number of recent/current public topics, would this make it any less time-consuming?

@BeccaMelhuish BeccaMelhuish added the estimated Issues that have dev time estimates added label Nov 12, 2024
@ilmartyrk ilmartyrk self-assigned this Nov 14, 2024
@github-project-automation github-project-automation bot moved this from Now - In Progress to Done in Citizen OS GitHub issue priorities Nov 21, 2024
@BeccaMelhuish BeccaMelhuish moved this from Done to In QA testing in Citizen OS GitHub issue priorities Nov 22, 2024
@ssin1901
Copy link

@BeccaMelhuish @ilmartyrk this fix hasn't been implemented in the test environment as the user added an idea but could not join the topic and could not take part in the voting either. Can I re-open?

Screenshot 2024-11-25 at 00 04 59

@BeccaMelhuish BeccaMelhuish reopened this Nov 25, 2024
@BeccaMelhuish BeccaMelhuish moved this from In QA - development to Now - Ready for dev in Citizen OS GitHub issue priorities Nov 25, 2024
@BeccaMelhuish BeccaMelhuish moved this from Now - Ready for dev to Now - In Progress in Citizen OS GitHub issue priorities Nov 25, 2024
@BeccaMelhuish
Copy link
Contributor

Yes please do just re-open and move back to 'in progress' if something isn't fixed :)

(@ilmartyrk please contradict if not, but I think this is what we agreed)

@ilmartyrk
Copy link
Member Author

@ssin1901 just to confirm did you test it in development.app.citizenos.com or in test.app.citizenos.com ? This fix is currently only in development.app.citizenos.com

@ssin1901
Copy link

@ilmartyrk ah, in test.app.citizenos.com. I'll test it in development.app.citizenos.com now

@ssin1901
Copy link

@ilmartyrk @BeccaMelhuish user added an idea but was not added to the topic (see screen recording)

Screen.Recording.2024-12-13.at.15.11.25.mov

@ssin1901
Copy link

Moving to in progress as fix is not implemented in developer environment yet

@ssin1901 ssin1901 moved this from In QA - development to Now - In Progress in Citizen OS GitHub issue priorities Dec 13, 2024
@BeccaMelhuish
Copy link
Contributor

Also @ilmartyrk if it makes sense to fix both at once, then there is now this quite closely related issue too: #1714

@ilmartyrk
Copy link
Member Author

@BeccaMelhuish I would rather keep these issues apart

@ilmartyrk
Copy link
Member Author

ilmartyrk commented Dec 16, 2024

@ssin1901 @BeccaMelhuish the feature is actually working, but I guess not working was the part that the participants number was not updated, this will need some thinking how to properly fix

@BeccaMelhuish
Copy link
Contributor

@ilmartyrk OK noted thank you, great that it's partially fixed already then! And as per the discussion in #1690, please also add people automatically to the topic when they turn on notifications :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request estimated Issues that have dev time estimates added
Projects
Status: Now - In Progress
Development

No branches or pull requests

5 participants