-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add participants to public topics automatically when they engage (add idea, like, vote, etc) #307
Comments
Triage 93. This needs more discussion. Sending it to In Prep. |
@kevincrepin @BeccaMelhuish check if the issue is relevant or not. |
How I saw this was that there are two ways to "join" a topic:
So I didn't see this so that the user would not be able to interact with the topic without joining it. Interacting includes joining. |
@kevincrepin totally agree - this makes a lot of sense to me. Anyone who has posted should be automatically turned into a participant, can't see any reason not to (or any reason to force them to actively click 'join' before they're allowed to post) :) Will tag @ssin1901 though in case she sees something I'm missing :) Will also move this to soon as it does seem relevant to fix soon-ish |
An example of this causing potential confusion/user issues in practice came to light with this one so I'll move it to 'Next?'. An umbrella organisation set their GA voting topic to public. As not everyone joined via a join link (presumably), they have more people having voted than they have registered participants: Anyone who votes should be automatically added as a participant, same as adding any other contribution (argument / idea / reply / reaction) |
Okay, estimated dev time is 3h, will add the users as participants to the topic when posting idea, argument/reply or casting their vote. My question is should we also do backward migration so that historic data would also change? This would take at least 8h to create a script that takes all the users that have done these actions in the past and are not members of the topics |
@ilmartyrk Wonderful. Should we also add them if they react too? (I.e. like an idea or argument or reply). Re historic data, that's a good question. My general feeling is that we haven't had enough really active public topics in the past for it to be worthwhile, and also it's unlikely that old public topics are getting looked at much. But.. there are some currently or recently active public topics for which it would be great to have the correct participant numbers showing (IOF for example, plus some DD Foundation ones for which the issue might possibly be relevant). If we were to select a small number of recent/current public topics, would this make it any less time-consuming? |
@BeccaMelhuish @ilmartyrk this fix hasn't been implemented in the test environment as the user added an idea but could not join the topic and could not take part in the voting either. Can I re-open? |
Yes please do just re-open and move back to 'in progress' if something isn't fixed :) (@ilmartyrk please contradict if not, but I think this is what we agreed) |
@ssin1901 just to confirm did you test it in development.app.citizenos.com or in test.app.citizenos.com ? This fix is currently only in development.app.citizenos.com |
@ilmartyrk ah, in test.app.citizenos.com. I'll test it in development.app.citizenos.com now |
@ilmartyrk @BeccaMelhuish user added an idea but was not added to the topic (see screen recording) Screen.Recording.2024-12-13.at.15.11.25.mov |
Moving to in progress as fix is not implemented in developer environment yet |
Also @ilmartyrk if it makes sense to fix both at once, then there is now this quite closely related issue too: #1714 |
@BeccaMelhuish I would rather keep these issues apart |
@ssin1901 @BeccaMelhuish the feature is actually working, but I guess not working was the part that the participants number was not updated, this will need some thinking how to properly fix |
@ilmartyrk OK noted thank you, great that it's partially fixed already then! And as per the discussion in #1690, please also add people automatically to the topic when they turn on notifications :) |
Currently any user can add arguments to public topic without being a member of that topic. In our redesign designs there is a text for users that are not members "Join this topic to engage in the discussion". It got me thinking that maybe we should add this extra step that users who want to join discussion should actually become members for the topic.
Pros:
Cons:
The text was updated successfully, but these errors were encountered: