Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for Citus table in worker_copy_table_to_node #7662

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Green-Chan
Copy link
Contributor

Fixes #6795

The worker_copy_table_to_node is not supposed to be called for Citus tables. When this function was initially introduced in #6098 , it had the respective check. But the check was omitted, since worker_copy_table_to_node called for Citus table finishes with error anyway:

ERROR: cannot execute a distributed query from a query on a shard
DETAIL: Executing a distributed query in a function call that may be pushed to a remote node can lead to incorrect results.

It turns out that in some cases this error does not occur. See #6795

I suggest restoring that check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

worker_copy_table_to_node UDF succeeds when expected to throw an error.
1 participant