Fix Isolation Test Failure in isolation_multiuser_locking in PG17 #7714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## naisila/pg17_support #7714 +/- ##
=====================================================
Coverage 89.61% 89.61%
=====================================================
Files 274 274
Lines 59689 59689
Branches 7446 7446
=====================================================
+ Hits 53490 53493 +3
+ Misses 4069 4066 -3
Partials 2130 2130 |
onurctirtir
reviewed
Nov 8, 2024
|
|
||
| step s1-insert: | ||
| UPDATE test_table SET column2 = 1; | ||
| <waiting ...> |
There was a problem hiding this comment.
this seems a bit suspicious as we were throwing a permission-check error in the older test output
There was a problem hiding this comment.
I suppose that because of this commit:
git.postgresql.org Git - postgresql.git/commitdiff
If you think that it is unrelated, ı Will looked into that more.
naisila
force-pushed
the
naisila/pg17_support
branch
from
70cf729 to
e4040dd
Compare
(cherry picked from commit ae3ed7d)
(cherry picked from commit 76f60a7)
(cherry picked from commit df9c7b4)
In PG17, the outer loop in acquire_sample_rows() changed from while (BlockSampler_HasMore(&bs)) to while (table_scan_analyze_next_block(scan, stream)) Relevant PG commit: 041b96802efa33d2bc9456f2ad946976b92b5ae1 postgres/postgres@041b968 It is expected that the scan_analyze_next_block function will check if there are any blocks left. So we add that check in columnar_scan_analyze_next_block (cherry picked from commit 7eb0ad5)
PG 17 added support for DEFAULT in ALTER TABLE .. SET ACCESS METHOD Relevant PG commit: d61a6cad6418f643a5773352038d0dfe5d3535b8 postgres/postgres@d61a6ca In that case, name in AlterTableCmd would be null. Add a null check here to avoid crash. (cherry picked from commit 71b9974)
…tests Fix pg15 pg16 multi_mx_create_table multi_schema_support Relevant PG commit: postgres/postgres@f696c0c f696c0cd5f299f1b51e214efc55a22a782cc175d (cherry picked from commit 17a2ed0)
Relevant PG commit: f69319f2f1fb16eda4b535bcccec90dff3a6795e postgres/postgres@f69319f (cherry picked from commit 6c12b10)
This PR addresses a regression test failure in the multi-mx feature of Citus with the new PostgreSQL 17 version. The regression was identified during the execution of multi-node tests, specifically targeting compatibility issues introduced with PostgreSQL 17. --------- Co-authored-by: Mehmet YILMAZ <[email protected]> (cherry picked from commit 70cf729)
This reverts commit e4040dd. Reverting for now as this commit is fixing more than one thing at once at multi_extension.out file Its a harmless revert for testing purposes
naisila
force-pushed
the
naisila/pg17_support
branch
from
04a8f6a to
b29c332
Compare
m3hm3t
force-pushed
the
m3hm3t/pg17_isolation_multiuser_lock
branch
from
1fbdd9f to
94bbb2e
Compare
naisila
force-pushed
the
naisila/pg17_support
branch
3 times, most recently
from
e12686a to
46dc966
Compare
naisila
force-pushed
the
naisila/pg17_support
branch
from
46dc966 to
6d036b0
Compare
naisila
force-pushed
the
naisila/pg17_support
branch
6 times, most recently
from
e108bb8 to
c396ce6
Compare
naisila
force-pushed
the
naisila/pg17_support
branch
7 times, most recently
from
1e55f40 to
1c39f95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances
isolation_multiuser_locking.spectest compatibility across multiple PostgreSQL versions by handling differences in error messages and behavior. Key updates include:Error Message Handling: Adjustments to manage version-specific error messages, ensuring consistent test results.
Modified to address variations in locking behavior across PostgreSQL versions, ensuring test stability in multiuser scenarios.
REINDEX Behavior Adjustment: This PR accounts for a behavioral change introduced in PostgreSQL by commit ecb0fd337, which alters how REINDEX interacts with system catalogs.
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=ecb0fd337