Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Versioning Error #625

Open
victhevenot opened this issue Jan 11, 2019 · 1 comment
Open

Upgrade Versioning Error #625

victhevenot opened this issue Jan 11, 2019 · 1 comment

Comments

@victhevenot
Copy link

If a component has upgrades all the way from 1.0, 1.1, 1.2....1.9 and then tries to add 1.10, the ugprade isn't run because it treats 1.10 and 1.1 the same. This happened in prod with the sites ad component for updating a flex size on an in article ad.
@elgreg
Copy link
Contributor

elgreg commented Jan 11, 2019

Would it be overkill to import and use https://www.npmjs.com/package/semver for the comparison?

@elgreg elgreg mentioned this issue Sep 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elgreg @victhevenot