Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amphora Plugins Auth Requirement #640

Open
jonwinton opened this issue Mar 15, 2019 · 0 comments · May be fixed by #657
Open

Amphora Plugins Auth Requirement #640

jonwinton opened this issue Mar 15, 2019 · 0 comments · May be fixed by #657
Assignees
Labels

Comments

@jonwinton
Copy link
Contributor

Description

Currently any Amphora plugin can only accept GET requests because of this line: https://github.com/clay/amphora/blob/master/lib/auth.js#L69

Reported by @jjpaulino

Steps to Reproduce

Steps to reproduce the behavior:

  1. Make any plugin which accepts a request other than GET or OPTIONS
  2. Execute a request to the plugin
  3. See requirement for authentication

Expected Behavior

A plugin should be able to opt-out of authentication requirements

Additional Context

We should make the authentication requirement a default but allow plugins to opt-out. This will require moving the function which is enforcing this to be applied individually to core routes and then a test for plugin routes will need to be added.

@jonwinton jonwinton added the bug label Mar 15, 2019
@pedro-rosario pedro-rosario mentioned this issue Apr 9, 2019
2 tasks
@pedro-rosario pedro-rosario linked a pull request May 1, 2019 that will close this issue
2 tasks
@TTaitFoster TTaitFoster reopened this Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants