Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quote values of type String #6

Open
close2 opened this issue Mar 19, 2016 · 4 comments
Open

quote values of type String #6

close2 opened this issue Mar 19, 2016 · 4 comments
Assignees
Milestone

Comments

@close2
Copy link
Owner

close2 commented Mar 19, 2016

[ '1', 3 ] should result in '"1",3'
Currently 1 is not quoted.

@close2 close2 self-assigned this Mar 19, 2016
@close2 close2 added this to the v4 milestone Mar 19, 2016
@Zectbumo
Copy link

No, this is not correct. In CSV there is no difference between 1,3 and "1",3. There is no int and string type in CSV like you might be thinking.

@close2
Copy link
Owner Author

close2 commented May 17, 2016

Agreed.

I've also received a bug report that numbers are not always quoted, which shouldn't be necessary.

I guess quoting behavior should be an enum: always,onlyStrings,onlyWhenNecessary (something like that)
This should be easy to implement, and make everyone happy.

Not sure about the default however.

@Zectbumo
Copy link

The enum would be nice. As for the default, I recommend quoting only when it is required. This will result in the smallest file size and will be easier to read the raw output.

@flutter-painter
Copy link

I also get :
"A value of type 'dynamic' can't be assigned to a variable of type 'String'."
In : lib/csv_settings_autodetection.dart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants