Increase vfio-ioctls coverage #2
Assignees
Comments
|
cc @zhabinecho |
|
Yeah, I'll cover it later. |
|
We found the unit tests for vfio-ioctls crate may require some real PCI devices. Current integration test of cloud-hypervisor vfio part use nested virtualization. For vfio-ioctls unit test we may need use a device which need exists in most of the platforms like USB? or through emulation? any suggestions? |
arronwy
pushed a commit
to arronwy/vfio-ioctls
that referenced
this issue
May 27, 2020
Some unit test may require interactive with real devices, we ignore them by default. Fixes cloud-hypervisor#2
arronwy
pushed a commit
to arronwy/vfio-ioctls
that referenced
this issue
May 27, 2020
Some unit test may require interactive with real devices, we ignore them by default. Fixes cloud-hypervisor#2
Merged
arronwy
pushed a commit
to arronwy/vfio-ioctls
that referenced
this issue
May 27, 2020
Some unit test may require interactive with real devices, we ignore them by default. Fixes cloud-hypervisor#2 Signed-off-by: Arron Wang <[email protected]>
arronwy
pushed a commit
to arronwy/vfio-ioctls
that referenced
this issue
Jun 2, 2020
Some unit test may require interactive with real devices, we ignore them by default. Fixes cloud-hypervisor#2 Signed-off-by: Arron Wang <[email protected]>
sameo
pushed a commit
that referenced
this issue
Jun 2, 2020
Some unit test may require interactive with real devices, we ignore them by default. Fixes #2 Signed-off-by: Arron Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
By adding unit tests. There currently are zero unit testing.
We won't be able to push that code upstream without at least some unit testing.
The text was updated successfully, but these errors were encountered: