Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max_lag is in nr of actions but lag is in nr of bytes #807

Closed
viktorerlingsson opened this issue Oct 15, 2024 · 0 comments · Fixed by #810 · May be fixed by #811
Closed

max_lag is in nr of actions but lag is in nr of bytes #807

viktorerlingsson opened this issue Oct 15, 2024 · 0 comments · Fixed by #810 · May be fixed by #811
Assignees

Comments

@viktorerlingsson
Copy link
Member

Should we maybe rename one or both to make it clearer what it means?

Discussion from here #805 (comment)

maybe max_lag_in_actions / lag_in_bytes?
maybe add lag_in_actions?


We go for a simple "lag_in_bytes", for 2.0. good enough.
In future release, we re-construct lag metrics and config so it makes more sense or is clearer for user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant