Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't unmap message segments before last consumer is done #825

Closed
snichme opened this issue Nov 1, 2024 · 2 comments
Closed

Don't unmap message segments before last consumer is done #825

snichme opened this issue Nov 1, 2024 · 2 comments
Assignees
Labels

Comments

@snichme
Copy link
Member

snichme commented Nov 1, 2024

Describe the bug

We have a bug (hard to trigger) that we may unmap message segments before the last consumer deliver loop has finish writing to the socket, causing a segmentation fault.

We should rethink when we do the unmap. Maybe a fiber waiting for all deliver loops to be done (using a WaitGroup).

@kickster97 kickster97 added the bug label Nov 11, 2024
@snichme
Copy link
Member Author

snichme commented Nov 20, 2024

@spuun solved by #850 right?

@spuun
Copy link
Member

spuun commented Dec 9, 2024

Yes, #850 solved this.

@spuun spuun closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants