Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve connection negotiation and channel_max enforcement #940

Merged
merged 9 commits into from
Feb 12, 2025
Merged

Improve connection negotiation and channel_max enforcement #940

merged 9 commits into from
Feb 12, 2025

Conversation

baelter
Copy link
Member

@baelter baelter commented Feb 10, 2025 •
edited
Loading

WHAT is this pull request doing?

  • Fixing channel_max and frame_max negotiation.
  • Enforces channel_max. Closes Server channel_max is not respected #939
  • Improves readability by using enum for Channel and Connection Close reply-code
  • Adds support for specs that need custom config values

HOW can this pull request be tested?

Specs

@baelter
Copy link
Member Author

baelter commented Feb 10, 2025

This is not actually a failing spec since amqp-client.cr guards against this: https://github.com/cloudamqp/amqp-client.cr/blob/main/src/amqp-client/connection.cr#L296

@baelter baelter changed the title Add failing spec for channel_max negotiation Improve connection start negotiation and enforcement Feb 11, 2025
@baelter baelter changed the title Improve connection start negotiation and enforcement Improve connection negotiation and channel_max enforcement Feb 11, 2025
@baelter baelter marked this pull request as ready for review February 11, 2025 16:22
@baelter baelter requested a review from a team as a code owner February 11, 2025 16:22
spuun
spuun approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@spuun spuun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/lavinmq/amqp/client.cr Outdated Show resolved Hide resolved
src/lavinmq/amqp/client.cr Outdated Show resolved Hide resolved
@baelter baelter merged commit f01449d into main Feb 12, 2025
20 of 25 checks passed
@baelter baelter deleted the channel_max branch February 12, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viktorerlingsson viktorerlingsson viktorerlingsson left review comments

@spuun spuun spuun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server channel_max is not respected
3 participants
@baelter @spuun @viktorerlingsson