New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need unit-test for start_esp.py #61

Open

qiwzhang opened this issue Jun 7, 2018 · 1 comment

Assignees

Contributor

qiwzhang commented Jun 7, 2018

Any changes to start_esp is not tested in this repo. has to reply on esp e2e test. start_esp.py has 3 parts

generate nginx.conf from template by flags,
generate server.conf from template by flags
remote fetching: token, metadata, service config.

I like to have 1) and 2) unit-test first. 3) may need mock servers.

qiwzhang assigned lei-tang

qiwzhang mentioned this issue

start_esp build compatibility with bazel #65

Closed

lei-tang mentioned this issue

Add the start_esp tests cloudendpoints/esp#417

Merged

Contributor

lei-tang commented Jul 19, 2018

#66 and cloudendpoints/esp#417 are created to add tests for start_esp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment