%-encoded characters in url path are not decoded during json-grpc transcoding

[ashi009]

We have a rpc method like the following:

  rpc GetBook(GetBookRequest) returns (Book) {
    option (google.api.http) = {
      get : "/v1/{name=books/*}",
    };
  }

When receiving a GET request like GET /books/something%26like%26this, the resource name books/something%26like%26this is passed in GetBookRequest.name field as it.

The tests in path_matcher_node_test.cc suggests this is the intended behavior. However, I found that fully_decode_reserved_expansion was added in http.proto. This new flag allows the user to force decoding of all %-encoded characters (if I understand it correctly), and it doesn't seem to have implemented in esp/grpc-httpjson-transcoding.

[ashi009]

Our RPCs are designed as follow: https://cloud.google.com/apis/design/resource_names#resource_name_vs_url

[fieryorc]

Running into the same issue. When we use our local grpc gateway (golang generated code), it does the right thing. However, ESP doesn't decode the values.

[qiwzhang]

Yes, the flag fully_decode_reserved_expansion is not supported by ESP.