You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Weak validation of http_status, so incorrect can register http status.
To Reproduce
Configure http_status:999
Expected behavior
Only existing http status codes can be registered.
Environment and versions
OS: All
Architecture: All
Version: 2024.12.2
Additional context
After this, I plan to create a PR, but fixing this issue requires modifications not only to cloudflared but also to the Web UI( https://one.dash.cloudflare.com/ ).
The text was updated successfully, but these errors were encountered:
Also there are some "Unofficial codes" that might be a valid use case (See wiki ), for which go's StatusText function (source) would not return any text.
For example HTTP 218, 509, 529, and many more
(Here is a screenshot from wiki page about the additional unofficial codes, used by cloudflare too)
In my opinion, this should not be done. We should allow any unofficial HTTP code, on any other custom HTTP code a user wants. This doesn't seem to pose any security risk.
Describe the bug
Weak validation of
http_status
, so incorrect can register http status.To Reproduce
http_status:999
Expected behavior
Only existing http status codes can be registered.
Environment and versions
Additional context
After this, I plan to create a PR, but fixing this issue requires modifications not only to cloudflared but also to the Web UI( https://one.dash.cloudflare.com/ ).
The text was updated successfully, but these errors were encountered: