Relace go-bindata with go:embed #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramprice
force-pushed
the
replace-go-bindata-with-go-embed
branch
11 times, most recently
from
3f26842 to
ab5e16d
Compare
selzoc
approved these changes
Sep 11, 2023
aramprice
force-pushed
the
replace-go-bindata-with-go-embed
branch
from
ab5e16d to
9db0fcd
Compare
- Update makefile to move expected data into place rather than invole `go-bindata` - Simplify call sites where `assets.Asset(...)` has been used
aramprice
force-pushed
the
replace-go-bindata-with-go-embed
branch
from
9db0fcd to
a3fc24c
Compare
aramprice
added a commit
to cloudfoundry/greenhouse-ci
that referenced
this pull request
Sep 14, 2023
- Update makefile to move expected data into place rather than invole `go-bindata` See: cloudfoundry/stembuild#23
|
This PR will need to be coordinated with a change to cloudfoundry/greenhouse-ci to remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-bindataassets.Asset(...)has been used