Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logger improvements #36

Merged
merged 5 commits into from
Jul 25, 2024
Merged

Logger improvements #36

merged 5 commits into from
Jul 25, 2024

Conversation

aramprice
Copy link
Member

  • colorlogger package looks more like log.Logger
  • VCenterPackager and VmdkPackager have a Logger member
  • VmdkPackager uses .Logger.Printf() instead of bespoke .Debugf() member

@aramprice aramprice requested review from ystros and selzoc July 23, 2024 23:58
@aramprice aramprice mentioned this pull request Jul 24, 2024
Merged
@aramprice aramprice requested a review from jpalermo July 24, 2024 17:34
@aramprice aramprice merged commit cdcfbd4 into master Jul 25, 2024
4 checks passed
@aramprice aramprice deleted the logger-improvements branch July 25, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selzoc selzoc selzoc approved these changes

@ystros ystros Awaiting requested review from ystros

@jpalermo jpalermo Awaiting requested review from jpalermo

Assignees
No one assigned
Labels
None yet
Projects
Foundational Infrastructure Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aramprice @selzoc