Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp.backend): Enable filtering for component instance without support group or service #180

Closed
2 tasks
Tracked by #181
lolaapenna opened this issue Aug 27, 2024 · 5 comments · Fixed by #407
Closed
2 tasks
Tracked by #181
Assignees

Comments

@lolaapenna
Copy link
Collaborator

lolaapenna commented Aug 27, 2024

Task Description
We need to have a design session to decide the following:

  • how to identify non-values
  • the pattern for non-existing - we can consider naming the list of component instances in this category (no service, no support group)

Acceptance Criteria:

  • ADR is discussed and there is a agreement to a solution
  • Filtering option is implemented according to the ADR

Expected Test:
Database-Layer, APP-Layer and E2E Test.

@MR2011
Copy link
Collaborator

MR2011 commented Sep 17, 2024

Having no service is not possible in the database:
https://github.com/cloudoperators/heureka/blob/main/internal/database/mariadb/init/schema.sql#L105

@lolaapenna
Copy link
Collaborator Author

Create an ADR considering the options.

@lolaapenna
Copy link
Collaborator Author

@dustindemmerle, could you kindly fill in the issue's Acceptance criteria and Expected Test sections?

@dustindemmerle
Copy link
Collaborator

ADR for Identification of Component Instances without support group or service:
https://codi.eu-nl-1.cloud.sap/DAyEAcAqQIS765JZyw0lYw?view

@lolaapenna
Copy link
Collaborator Author

Decision has been made, we just need to update the ADR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment