Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(authN) - Add updated_by to inserts #360 #410

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

michalkrzyz
Copy link
Collaborator

@michalkrzyz michalkrzyz commented Nov 28, 2024

Add assignments in app handlers
Add inserts in database querries
Adjust tests

Description

issue-360 - add updated_by change for insert of element

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Add assignments in app handlers
Add inserts in database querries
Adjust tests
@drochow drochow merged commit 5229ddb into main Nov 28, 2024
7 checks passed
@drochow drochow deleted the mikrzyz/issue-360 branch November 28, 2024 10:48
dustindemmerle pushed a commit that referenced this pull request Dec 2, 2024
Add assignments in app handlers
Add inserts in database querries
Adjust tests
drochow added a commit that referenced this pull request Dec 3, 2024
…o OnComponentVersionAttachmentToIssue event (#403)

* feat(issueMatch): added created_by field to new issue match in OnComponentVersionAttachmentToIssue event

* updating issue_handler_events.go + test

* docs(comp.backend): ADR - Enable filtering for component instance without support group or service

* feat(authN) - Add updated_by to inserts #360 (#410)

Add assignments in app handlers
Add inserts in database querries
Adjust tests

* ci(keppel): seperate user and keppel domain (#414)

* ci: seperated the user domain from the keppel domain

* ci: fixed typo

---------

Co-authored-by: David Rochow <[email protected]>
Co-authored-by: Dustin Demmerle <[email protected]>
Co-authored-by: dustindemmerle <[email protected]>
Co-authored-by: michalkrzyz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants