Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atmos vendor pull --tags ... --dry-run doesn't do a full run #792

Open
mss opened this issue Nov 18, 2024 · 0 comments · May be fixed by #768
Open

atmos vendor pull --tags ... --dry-run doesn't do a full run #792

mss opened this issue Nov 18, 2024 · 0 comments · May be fixed by #768
Labels
bug 🐛 An issue with the system Short List

Comments

@mss
Copy link
Contributor

mss commented Nov 18, 2024

Describe the Bug

When I execute atmos vendor pull --tags example/mixins --dry-run it shows only the first pull whereas atmos vendor pull --tags example/mixins actually pulls them all.

# atmos vendor pull --tags example/mixins --dry-run
Processing vendor config file 'vendor.yaml' for tags {example/mixins}
Pulling sources for the component 'example/mixins/context/v1.1' from './components/terraform/mixins/context/v1.1' into 'components/terraform/example/v0.1'
# atmos vendor pull --tags example/mixins 
Processing vendor config file 'vendor.yaml' for tags {example/mixins}
Pulling sources for the component 'example/mixins/context/v1.1' from './components/terraform/mixins/context/v1.1' into 'components/terraform/example/v0.1'
Pulling sources for the component 'example/mixins/context/v1.1' from './components/terraform/mixins/context/v1.1' into 'components/terraform/example/v0.2'
Pulling sources for the component 'example/mixins/context/v1.1' from './components/terraform/mixins/context/v1.1' into 'components/terraform/example/v0.3'

Expected Behavior

# atmos vendor pull --tags example/mixins --dry-run
Processing vendor config file 'vendor.yaml' for tags {example/mixins}
Pulling sources for the component 'example/mixins/context/v1.1' from './components/terraform/mixins/context/v1.1' into 'components/terraform/example/v0.1'
Pulling sources for the component 'example/mixins/context/v1.1' from './components/terraform/mixins/context/v1.1' into 'components/terraform/example/v0.2'
Pulling sources for the component 'example/mixins/context/v1.1' from './components/terraform/mixins/context/v1.1' into 'components/terraform/example/v0.3'

Steps to Reproduce

Try something like this vendor.yaml:

apiVersion: atmos/v1
kind: AtmosVendorConfig
metadata:
  name: example
  description: ...
spec:
  sources:
    - component: example/v0.1
      version: v2.6.0
      source: git::https://git.example.com/example.git//aws/example?depth=1&ref={{.Version}}
      tags:
        - example
      targets:
        - components/terraform/{{.Component}}

    - component: example/v0.2
      version: v2.7.6
      source: git::https://git.example.com/example.git//aws/example?depth=1&ref={{.Version}}
      tags:
        - example
      targets:
        - components/terraform/{{.Component}}

    - component: example/v0.3
      version: v2.12.0
      source: git::https://git.example.com/example.git//aws/example?depth=1&ref={{.Version}}
      tags:
        - example
      targets:
        - components/terraform/{{.Component}}

    # NOTE: Add any new components to this list
    - component: example/mixins/context/v1.1
      source: components/terraform/{{with .Component | splitList "/"}}{{slice . 1 | join "/"}}{{end}}
      tags:
        - example
        - example/mixins
      targets:
        - components/terraform/example/v0.1
        - components/terraform/example/v0.2
        - components/terraform/example/v0.3

Screenshots

No response

Environment

  • Version: 1.105.0

Additional Context

No response

@mss mss added the bug 🐛 An issue with the system label Nov 18, 2024
@osterman osterman linked a pull request Nov 18, 2024 that will close this issue
@osterman osterman moved this to In Progress in Atmos Development Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system Short List
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants