Explicitly close connection after response body to support servers ignoring Connection: close request header

[jmoo]

Some HTTP/1.1 servers do not honor the Connection: Close header. bufferResponse will never resolve when making requests to these.

Here is an example fix:
jmoo@a9c27ec

The only problem is that \React\Promise\Stream\buffer doesn't resolve when maxLength is reached and changing it to resolve would be a BC break. We'd have to roll our own or start a discussion over on https://github.com/reactphp/promise-stream about adding a $resolveOnMaxLengthReached flag or something.

Related to #89

[clue]

@jmoo This is an interesting issue!

Some HTTP/1.1 servers do not honor the Connection: Close header.

The server is clearly at fault for violating HTTP specs here: https://tools.ietf.org/html/rfc7230#section-6.3

That being said, I agree that this is something we should support nonetheless. The implementation likely depends on reactphp/http-client#92 being addressed first. Once that PR is in, this should be trivial here.

[bartvanhoutte]

Seems like I'm running into this as well. Any workarounds for the moment?

[jmoo]

Seems like I'm running into this as well. Any workarounds for the moment?

This was a couple of years ago but at the time I just ended up handling the buffering manually:
https://github.com/jmoo/chrome-reactphp/blob/04340bdb1f0a0371ee21dc2bc30fc12a0ec0ab1b/src/Async/Client.php#L118

[bartvanhoutte]

@jmoo just implemented something similar.

[clue]

Finally fixed via #161, please let me know if this works for you 👍

Thanks for reporting and for the possible workaround!