Skip to content

Commit 05efc77

Browse files
David AbdurachmanovDavid Abdurachmanov
David Abdurachmanov
authored and
David Abdurachmanov
committed
Dictionary (classes*h) must have unique namespace or/and struct name
The patch does minor cleanups and create unique namespaces based on package name. The change is needed for ROOT6 as classes*h files becomes a payload embedded into ROOT6 dictionary, which is executed in an interpreter (Cling) during dictionary loading procedure. Signed-off-by: David Abdurachmanov <[email protected]>
1 parent 0491195 commit 05efc77

File tree

182 files changed

+224
-248
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

182 files changed

+224
-248
lines changed

Alignment/LaserAlignment/src/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#include "Alignment/LaserAlignment/interface/TsosVectorCollection.h"
22
#include "DataFormats/Common/interface/Wrapper.h"
33

4-
namespace {
4+
namespace Alignment_LaserAlignment {
55
struct dictionary {
66
TsosVectorCollection tsosesColl;
77
edm::Wrapper<TsosVectorCollection> tsosesWrappedColl;

AnalysisDataFormats/EWK/src/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#include <map>
2121

2222

23-
namespace {
23+
namespace AnalysisDataFormats_EWK {
2424
struct dictionary {
2525
std::vector<reco::WMuNuCandidate> v1;
2626
edm::Wrapper<std::vector<reco::WMuNuCandidate> > c1;

AnalysisDataFormats/Egamma/src/classes.h

+2-4
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,8 @@
33
#include "AnalysisDataFormats/Egamma/interface/ElectronIDAssociation.h"
44
#include "DataFormats/Common/interface/RefToBase.h"
55

6-
namespace
7-
{
8-
struct dictionary
9-
{
6+
namespace AnalysisDataFormats_Egamma {
7+
struct dictionary {
108
reco::ElectronIDCollection c1;
119
edm::Wrapper<reco::ElectronIDCollection> w1;
1210
edm::Ref<reco::ElectronIDCollection> r1;

AnalysisDataFormats/SUSYBSMObjects/src/classes.h

+1-5
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@
44
#include "AnalysisDataFormats/SUSYBSMObjects/interface/HSCPDeDxInfo.h"
55
#include "AnalysisDataFormats/SUSYBSMObjects/interface/MuonSegment.h"
66

7-
namespace {
8-
namespace {
7+
namespace AnalysisDataFormats_SUSYBSMObjects {
98
susybsm::HSCParticle pa;
109
/* susybsm::DriftTubeTOF dtitof;
1110
@@ -66,7 +65,4 @@ namespace {
6665
edm::Wrapper<susybsm::HSCPDeDxInfo> hscpDEDXW;
6766
edm::Wrapper<susybsm::HSCPDeDxInfoCollection> hscpDEDXcW;
6867
edm::Wrapper<susybsm::HSCPDeDxInfoValueMap> hscpDEDXvmW;
69-
70-
71-
}
7268
}

AnalysisDataFormats/TopObjects/src/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
#include "DataFormats/Common/interface/Wrapper.h"
1616
#include "TString.h"
1717

18-
namespace {
18+
namespace AnalysisDataFormats_TopObjects {
1919
struct dictionary {
2020
TtGenEvent ttgen;
2121
StGenEvent stgen;

AnalysisDataFormats/TrackInfo/src/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
#include <vector>
1010

1111

12-
namespace {
12+
namespace AnalysisDataFormats_TrackInfo {
1313
struct dictionary {
1414

1515
reco::TrackingStateInfo tsi;

CondCore/ORA/test/classes.h

+12-10
Original file line numberDiff line numberDiff line change
@@ -1416,16 +1416,18 @@ class SH {
14161416

14171417
} // namespace testORA
14181418

1419-
namespace {
1420-
std::vector<double>::iterator dummy1;
1421-
std::vector<int>::iterator dummy2;
1422-
std::vector<int16_t>::iterator dummy3;
1423-
std::vector<short>::iterator dummy4;
1424-
std::vector<float>::iterator dummy5;
1425-
std::vector<testORA::Entry>::iterator dummy6;
1426-
std::vector<testORA::SiStripNoises::DetRegistry>::iterator dummy7;
1427-
std::vector<std::vector<double> >::iterator dummy8;
1428-
std::pair<size_t,testORA::SM> dummy9;
1419+
namespace CondCore_ORA {
1420+
struct dictionary {
1421+
std::vector<double>::iterator dummy1;
1422+
std::vector<int>::iterator dummy2;
1423+
std::vector<int16_t>::iterator dummy3;
1424+
std::vector<short>::iterator dummy4;
1425+
std::vector<float>::iterator dummy5;
1426+
std::vector<testORA::Entry>::iterator dummy6;
1427+
std::vector<testORA::SiStripNoises::DetRegistry>::iterator dummy7;
1428+
std::vector<std::vector<double> >::iterator dummy8;
1429+
std::pair<size_t,testORA::SM> dummy9;
1430+
};
14291431
}
14301432

14311433
#endif

CondCore/RegressionTest/test/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11

22
#include "CondCore/RegressionTest/interface/RegressionTestPayload.h"
3-
namespace {
3+
namespace CondCore_RegressionTest {
44
struct dictionary {
55
std::vector<double>::iterator dummy1;
66
std::vector<int>::iterator dummy2;

CondCore/Utilities/src/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#include "CondCore/Utilities/interface/CondBasicIter.h"
22
#include <iostream>
33

4-
namespace {
4+
namespace CondCore_Utilities {
55
struct dictionary {
66
};
77
}

CondFormats/BTauObjects/src/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
#include "CondFormats/BTauObjects/interface/CombinedTauTagCalibration.h"
77

88

9-
namespace {
9+
namespace CondFormats_BTauObjects {
1010
struct dictionary {
1111
std::vector<float> b1;
1212

CondFormats/CSCObjects/src/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
#include "CondFormats/CSCObjects/interface/CSCDBGasGainCorrection.h"
2323

2424

25-
namespace {
25+
namespace CondFormats_CSCObjects {
2626
struct dictionary {
2727

2828
std::vector<CSCPedestals::Item> pedcontainer1;

CondFormats/Calibration/src/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
#include "CondFormats/Calibration/interface/Conf.h"
1616
#include "CondFormats/Calibration/interface/big.h"
1717

18-
namespace {
18+
namespace CondFormats_Calibration {
1919
struct dictionary {
2020
fixedArray<unsigned short,2097> d;
2121
std::map<std::string, Algo> e;

CondFormats/CastorObjects/src/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
#include "CondFormats/CastorObjects/interface/CastorSaturationCorr.h"
1414
#include "CondFormats/CastorObjects/interface/CastorSaturationCorrs.h"
1515

16-
namespace {
16+
namespace CondFormats_CastorObjects {
1717
struct dictionary {
1818
CastorPedestals mypeds;
1919
std::vector<CastorPedestal> mypedsVec;

CondFormats/Common/src/classes.h

+4-12
Original file line numberDiff line numberDiff line change
@@ -12,25 +12,17 @@
1212

1313
#include <vector>
1414

15-
namespace {
16-
namespace {
17-
struct dictionaries {
18-
};
19-
20-
struct Dummy {
21-
std::map<unsigned long long,unsigned long long> dummyForTests;
22-
std::map<unsigned long long,unsigned long long>::value_type dummyForTest2;
15+
namespace CondFormats_Common {
16+
struct dictionary {
17+
std::map<unsigned long long,unsigned long long> dummyForTests;
18+
std::map<unsigned long long,unsigned long long>::value_type dummyForTest2;
2319

2420
DropBoxMetadata::Parameters aparam;
2521
std::pair<std::string, DropBoxMetadata::Parameters> apair1;
2622
std::pair<const std::basic_string<char>, DropBoxMetadata::Parameters> apair2;
2723

2824
std::map<std::string, DropBoxMetadata::Parameters> amap1;
2925
std::map<const std::basic_string<char>, DropBoxMetadata::Parameters> amap2;
30-
3126
};
32-
33-
}
34-
3527
}
3628

CondFormats/DQMObjects/src/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
#include "CondFormats/DQMObjects/interface/HDQMSummary.h"
33

44

5-
namespace {
5+
namespace CondFormats_DQMObjects {
66
struct dictionary {
77

88
std::vector<std::string>::iterator tmp30;

CondFormats/DTObjects/src/classes.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
#include "CondFormats/DTObjects/interface/DTKeyedConfig.h"
2828
#include "CondFormats/DTObjects/interface/DTTPGParameters.h"
2929

30-
namespace {
30+
namespace CondFormats_DTObjects {
3131
struct dictionary {
3232
// std::pair< DTT0Id, DTT0Data> t0Pair;
3333
std::pair< DTTtrigId, DTTtrigData> tTrigPair;
@@ -79,7 +79,7 @@ namespace {
7979

8080
/*
8181
// wrapper declarations
82-
namespace {
82+
namespace CondFormats_DTObjects {
8383
struct wrappers {
8484
pool::Ptr<DTReadOutMapping > pMap;
8585
cond::DataWrapper<DTReadOutMapping > dwMap;

CondFormats/ESObjects/src/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#include "CondFormats/ESObjects/interface/ESRecHitRatioCuts.h"
2121
#include "CondFormats/ESObjects/interface/ESTimeSampleWeights.h"
2222

23-
namespace{
23+
namespace CondFormats_ESObjects {
2424
struct dictionary {
2525

2626
ESCondObjectContainer<ESPedestal> ESPedestalsMap;

CondFormats/EcalObjects/src/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262

6363

6464

65-
namespace{
65+
namespace CondFormats_EcalObjects {
6666
struct dictionary {
6767

6868
std::vector<EcalChannelStatusCode> v_ecalChannelStatusCode;

CondFormats/EgammaObjects/src/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
#include "CondFormats/EgammaObjects/interface/GBRTree2D.h"
77
#include "CondFormats/EgammaObjects/interface/GBRForest2D.h"
88

9-
namespace {
9+
namespace CondFormats_EgammaObjects {
1010
struct dictionary {
1111
ElectronLikelihoodCategoryData a;
1212

CondFormats/HIObjects/src/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
#include <vector>
55

6-
namespace {
6+
namespace CondFormats_HIObjects {
77
struct dictionary{
88
std::vector<CentralityTable::CBin> dummy;
99
std::vector<RPFlatParams::EP> yummy;

CondFormats/HcalObjects/src/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
#include "CondFormats/HcalObjects/interface/AllObjects.h"
44

5-
namespace {
5+
namespace CondFormats_HcalObjects {
66
struct dictionary {
77

88
HcalPedestals mypeds();

CondFormats/JetMETObjects/src/classes.h

+15-11
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,18 @@
77
#include "CondFormats/JetMETObjects/interface/FFTJetCorrectorParameters.h"
88

99
#include <vector>
10-
11-
JetCorrectorParameters corr;
12-
JetCorrectorParameters::Definitions def;
13-
JetCorrectorParameters::Record record;
14-
std::vector<JetCorrectorParameters> corrv;
15-
std::vector<JetCorrectorParameters::Record> recordv;
16-
JetCorrectorParametersCollection coll;
17-
JetCorrectorParametersCollection::pair_type pair_type;
18-
JetCorrectorParametersCollection::collection_type colltype;
19-
std::vector<JetCorrectorParametersCollection> collv;
20-
FFTJetCorrectorParameters fftcorr;
10+
11+
namespace CondFormats_JetMETObjects {
12+
struct dictionary {
13+
JetCorrectorParameters corr;
14+
JetCorrectorParameters::Definitions def;
15+
JetCorrectorParameters::Record record;
16+
std::vector<JetCorrectorParameters> corrv;
17+
std::vector<JetCorrectorParameters::Record> recordv;
18+
JetCorrectorParametersCollection coll;
19+
JetCorrectorParametersCollection::pair_type pair_type;
20+
JetCorrectorParametersCollection::collection_type colltype;
21+
std::vector<JetCorrectorParametersCollection> collv;
22+
FFTJetCorrectorParameters fftcorr;
23+
};
24+
}

CondFormats/L1TObjects/src/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
#include "CondFormats/L1TObjects/interface/L1RPCHsbConfig.h"
4545

4646

47-
namespace {
47+
namespace CondFormats_L1TObjects {
4848
struct dictionary {
4949
std::vector<L1MuDTExtLut::LUT> dummy3 ;
5050
std::vector<L1GtMuonTemplate> dummy4 ;

CondFormats/Luminosity/src/classes.h

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
#include "CondFormats/Luminosity/interface/LumiSectionData.h"
2-
namespace {
2+
3+
namespace CondFormats_Luminosity {
4+
struct dictionary {
35
std::vector<lumi::BunchCrossingInfo>::iterator tmp1;
46
std::vector<lumi::HLTInfo>::iterator tmp2;
57
std::vector<lumi::TriggerInfo>::iterator tmp3;
8+
};
69
}

CondFormats/OptAlignObjects/src/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
//template std::vector< PXsensors::Item >::const_iterator;
3333
//template edm::Wrapper<OpticalAlignments>;
3434

35-
namespace{
35+
namespace CondFormats_OptAlignObjects {
3636
struct dictionary {
3737
std::vector<OpticalAlignInfo> optaligninfovec;
3838
std::vector<MBAChBenchCalPlateData> mbacalvec;

CondFormats/PhysicsToolsObjects/src/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
#include "CondFormats/PhysicsToolsObjects/interface/PhysicsTFormulaPayload.h"
1515

1616

17-
namespace { // anonymous
17+
namespace CondFormats_PhysicsToolsObjects { // anonymous
1818
struct dictionary {
1919

2020
#ifdef STD_DICTIONARIES_STUFF_MISSING

CondFormats/RPCObjects/src/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
#include "CondFormats/RPCObjects/interface/RPCObGasMix.h"
3333
#include "CondFormats/RPCObjects/interface/RPCObGasHum.h"
3434

35-
namespace{
35+
namespace CondFormats_RPCObjects {
3636
struct dictionary {
3737
std::vector<ChamberStripSpec> theStrips;
3838

CondFormats/RecoMuonObjects/src/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#include "CondFormats/RecoMuonObjects/interface/MuScleFitDBobject.h"
22

3-
namespace {
3+
namespace CondFormats_RecoMuonObjects {
44
struct dictionary {
55
// std::vector<PhysicsTools::Calibration::HistogramD2D> a;
66
MuScleFitDBobject e;

CondFormats/RunInfo/src/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
#include "CondFormats/RunInfo/interface/L1TriggerScaler.h"
55
#include "CondFormats/RunInfo/interface/MixingModuleConfig.h"
66
#include "CondFormats/RunInfo/interface/FillInfo.h"
7-
namespace {
7+
namespace CondFormats_RunInfo {
88
struct dictionary {
99
std::vector<runinfo_test::RunNumber::Item>::iterator tmp0;
1010
std::vector<L1TriggerScaler::Lumi>::iterator tmp1;

CondFormats/SiPixelObjects/src/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ template class PixelDCSObject<bool>;
1616
template class PixelDCSObject<float>;
1717
template class PixelDCSObject<CaenChannel>;
1818

19-
namespace {
19+
namespace CondFormats_SiPixelObjects {
2020
struct dictionary {
2121
std::map<SiPixelFedCablingMap::Key, sipixelobjects::PixelROC> theMap;
2222
std::pair<const SiPixelFedCablingMap::Key, sipixelobjects::PixelROC> theMapValueT;

CondFormats/SiStripObjects/src/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
#include "CondFormats/SiStripObjects/interface/SiStripSummary.h"
1515
#include "CondFormats/SiStripObjects/interface/SiStripConfObject.h"
1616

17-
namespace {
17+
namespace CondFormats_SiStripObjects {
1818
struct dictionary {
1919
std::vector< std::vector<FedChannelConnection> > tmp1;
2020

CondTools/Utilities/test/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
#include <iostream>
1616

17-
namespace {
17+
namespace CondTools_Utilities {
1818
struct dictionary {
1919

2020
CondCachedIter<Pedestals> dummy0;

DPGAnalysis/SiStripTools/src/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
#include "DataFormats/Common/interface/Wrapper.h"
1010

11-
namespace {
11+
namespace DPGAnalysis_SiStripTools {
1212
struct dictionary {
1313
TinyEventCollection dummycoll;
1414
SingleSiStripDigiMultiplicity dummy1;

DQM/SiPixelHistoricInfoClient/interface/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
#include "DQM/SiPixelHistoricInfoClient/interface/HDQMInspectorConfigSiPixel.h"
44

5-
namespace {
5+
namespace DQM_SiPixelHistoricInfoClient {
66
struct dictionary {
77
HDQMInspectorConfigSiPixel RealDummyDum;
88
};

DQM/SiStripHistoricInfoClient/interface/classes.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
#include "DQM/SiStripHistoricInfoClient/interface/HDQMInspectorConfigSiStrip.h"
44
#include "DQM/SiStripHistoricInfoClient/interface/HDQMInspectorConfigTracking.h"
55

6-
namespace {
6+
namespace DQM_SiStripHistoricInfoClient {
77
struct dictionary {
88
HDQMInspectorConfigSiStrip dummy1;
99
HDQMInspectorConfigTracking dummy2;

0 commit comments

Comments
 (0)