Skip to content

Commit b6735b7

Browse files
committed
migrate to esconsumes several test codes in the SiStrip area
1 parent 30bb8dc commit b6735b7

File tree

11 files changed

+119
-245
lines changed

11 files changed

+119
-245
lines changed

CalibFormats/SiStripObjects/test/plugins/module.cc

-4
This file was deleted.

CalibFormats/SiStripObjects/test/plugins/testSiStripHashedDetId.cc

+32-10
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,18 @@
1+
// system includes
2+
#include <algorithm>
3+
#include <iostream>
4+
#include <sstream>
5+
#include <time.h>
6+
#include <vector>
7+
#include <cstdint>
18

9+
// user includes
210
#include "CalibFormats/SiStripObjects/interface/SiStripHashedDetId.h"
3-
#include "CalibFormats/SiStripObjects/test/plugins/testSiStripHashedDetId.h"
411
#include "DataFormats/SiStripCommon/interface/SiStripConstants.h"
12+
#include "FWCore/Framework/interface/MakerMacros.h"
513
#include "FWCore/Framework/interface/ESHandle.h"
614
#include "FWCore/Framework/interface/Event.h"
15+
#include "FWCore/Framework/interface/one/EDAnalyzer.h"
716
#include "FWCore/MessageLogger/interface/MessageLogger.h"
817
#include "Geometry/CommonDetUnit/interface/GeomDet.h"
918
#include "Geometry/CommonDetUnit/interface/GeomDetType.h"
@@ -12,18 +21,30 @@
1221
#include "Geometry/TrackerGeometryBuilder/interface/StripGeomDetType.h"
1322
#include "Geometry/TrackerGeometryBuilder/interface/StripGeomDetUnit.h"
1423
#include "Geometry/TrackerGeometryBuilder/interface/TrackerGeometry.h"
15-
#include <algorithm>
16-
#include <iostream>
17-
#include <sstream>
18-
#include <time.h>
19-
#include <vector>
20-
#include <cstdint>
24+
25+
/**
26+
@class test_SiStripHashedDetId
27+
@author R.Bainbridge
28+
@brief Simple class that tests SiStripHashedDetId.
29+
*/
30+
class testSiStripHashedDetId : public edm::one::EDAnalyzer<> {
31+
public:
32+
testSiStripHashedDetId(const edm::ParameterSet &);
33+
~testSiStripHashedDetId();
34+
35+
void initialize(edm::EventSetup const &);
36+
void analyze(const edm::Event &, const edm::EventSetup &);
37+
38+
private:
39+
//-------------- member data ----------------//
40+
const edm::ESGetToken<TrackerGeometry, TrackerDigiGeometryRecord> geomToken_;
41+
};
2142

2243
using namespace sistrip;
2344

2445
// -----------------------------------------------------------------------------
2546
//
26-
testSiStripHashedDetId::testSiStripHashedDetId(const edm::ParameterSet &pset) {
47+
testSiStripHashedDetId::testSiStripHashedDetId(const edm::ParameterSet &pset) : geomToken_(esConsumes()) {
2748
edm::LogVerbatim(mlDqmCommon_) << "[testSiStripHashedDetId::" << __func__ << "]"
2849
<< " Constructing object...";
2950
}
@@ -42,8 +63,7 @@ void testSiStripHashedDetId::initialize(const edm::EventSetup &setup) {
4263
<< " Tests the generation of DetId hash map...";
4364

4465
// Retrieve geometry
45-
edm::ESHandle<TrackerGeometry> geom;
46-
setup.get<TrackerDigiGeometryRecord>().get(geom);
66+
edm::ESHandle geom = setup.getHandle(geomToken_);
4767

4868
// Build list of DetIds
4969
std::vector<uint32_t> dets;
@@ -182,3 +202,5 @@ void testSiStripHashedDetId::analyze(const edm::Event &event, const edm::EventSe
182202
LogTrace(mlDqmCommon_) << "[testSiStripHashedDetId::" << __func__ << "]"
183203
<< " Analyzing run/event " << event.id().run() << "/" << event.id().event();
184204
}
205+
206+
DEFINE_FWK_MODULE(testSiStripHashedDetId);

CalibFormats/SiStripObjects/test/plugins/testSiStripHashedDetId.h

-23
This file was deleted.

CalibTracker/SiStripESProducers/test/CheckPhase2Cabling.cc

+6-67
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
// user include files
2424
#include "FWCore/Framework/interface/Frameworkfwd.h"
25-
#include "FWCore/Framework/interface/EDAnalyzer.h"
25+
#include "FWCore/Framework/interface/one/EDAnalyzer.h"
2626
#include "FWCore/Framework/interface/Event.h"
2727
#include "FWCore/Framework/interface/EventSetup.h"
2828
#include "FWCore/Framework/interface/ESHandle.h"
@@ -40,48 +40,26 @@
4040
// class declaration
4141
//
4242

43-
class CheckPhase2Cabling : public edm::EDAnalyzer {
43+
class CheckPhase2Cabling : public edm::one::EDAnalyzer<> {
4444
public:
4545
explicit CheckPhase2Cabling(const edm::ParameterSet&);
4646
~CheckPhase2Cabling();
4747

4848
static void fillDescriptions(edm::ConfigurationDescriptions& descriptions);
4949

5050
private:
51-
virtual void beginJob();
5251
virtual void analyze(const edm::Event&, const edm::EventSetup&);
53-
virtual void endJob();
54-
55-
//virtual void beginRun(edm::Run const&, edm::EventSetup const&);
56-
//virtual void endRun(edm::Run const&, edm::EventSetup const&);
57-
//virtual void beginLuminosityBlock(edm::LuminosityBlock const&, edm::EventSetup const&);
58-
//virtual void endLuminosityBlock(edm::LuminosityBlock const&, edm::EventSetup const&);
5952

6053
// ----------member data ---------------------------
54+
const edm::ESGetToken<Phase2TrackerCabling, Phase2TrackerCablingRcd> cablingToken_;
6155
};
6256

63-
//
64-
// constants, enums and typedefs
65-
//
66-
67-
//
68-
// static data member definitions
69-
//
70-
7157
//
7258
// constructors and destructor
7359
//
74-
CheckPhase2Cabling::CheckPhase2Cabling(const edm::ParameterSet& iConfig)
75-
76-
{
77-
//now do what ever initialization is needed
78-
}
79-
80-
CheckPhase2Cabling::~CheckPhase2Cabling() {
81-
// do anything here that needs to be done at desctruction time
82-
// (e.g. close files, deallocate resources etc.)
83-
}
60+
CheckPhase2Cabling::CheckPhase2Cabling(const edm::ParameterSet& iConfig) : cablingToken_(esConsumes()) {}
8461

62+
CheckPhase2Cabling::~CheckPhase2Cabling() = default;
8563
//
8664
// member functions
8765
//
@@ -90,8 +68,7 @@ CheckPhase2Cabling::~CheckPhase2Cabling() {
9068
void CheckPhase2Cabling::analyze(const edm::Event& iEvent, const edm::EventSetup& iSetup) {
9169
using namespace edm;
9270

93-
ESHandle<Phase2TrackerCabling> cablingHandle;
94-
iSetup.get<Phase2TrackerCablingRcd>().get(cablingHandle);
71+
ESHandle<Phase2TrackerCabling> cablingHandle = iSetup.getHandle(cablingToken_);
9572

9673
// print general information about the cabling
9774
std::cout << cablingHandle->summaryDescription() << std::endl;
@@ -116,44 +93,6 @@ void CheckPhase2Cabling::analyze(const edm::Event& iEvent, const edm::EventSetup
11693
std::cout << powerGroup.description(1) << std::endl;
11794
}
11895

119-
// ------------ method called once each job just before starting event loop ------------
120-
void CheckPhase2Cabling::beginJob() {}
121-
122-
// ------------ method called once each job just after ending the event loop ------------
123-
void CheckPhase2Cabling::endJob() {}
124-
125-
// ------------ method called when starting to processes a run ------------
126-
/*
127-
void
128-
CheckPhase2Cabling::beginRun(edm::Run const&, edm::EventSetup const&)
129-
{
130-
}
131-
*/
132-
133-
// ------------ method called when ending the processing of a run ------------
134-
/*
135-
void
136-
CheckPhase2Cabling::endRun(edm::Run const&, edm::EventSetup const&)
137-
{
138-
}
139-
*/
140-
141-
// ------------ method called when starting to processes a luminosity block ------------
142-
/*
143-
void
144-
CheckPhase2Cabling::beginLuminosityBlock(edm::LuminosityBlock const&, edm::EventSetup const&)
145-
{
146-
}
147-
*/
148-
149-
// ------------ method called when ending the processing of a luminosity block ------------
150-
/*
151-
void
152-
CheckPhase2Cabling::endLuminosityBlock(edm::LuminosityBlock const&, edm::EventSetup const&)
153-
{
154-
}
155-
*/
156-
15796
// ------------ method fills 'descriptions' with the allowed parameters for the module ------------
15897
void CheckPhase2Cabling::fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
15998
//The following says we do not know what parameters are allowed so do no validation

CalibTracker/SiStripESProducers/test/SealModules.cc

-7
This file was deleted.

CalibTracker/SiStripESProducers/test/testSiStripQualityESProducer.cc

+42-12
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,46 @@
1-
#include "CalibFormats/SiStripObjects/interface/SiStripQuality.h"
2-
#include "CalibTracker/Records/interface/SiStripQualityRcd.h"
3-
4-
#include "CalibTracker/SiStripESProducers/test/testSiStripQualityESProducer.h"
5-
1+
// system includes
62
#include <iostream>
73
#include <stdio.h>
84
#include <sys/time.h>
95
#include <sstream>
106

7+
// user include files
8+
#include "FWCore/Framework/interface/Frameworkfwd.h"
9+
#include "FWCore/Framework/interface/one/EDAnalyzer.h"
10+
#include "FWCore/Framework/interface/Event.h"
11+
#include "FWCore/Framework/interface/EventSetup.h"
12+
#include "FWCore/ServiceRegistry/interface/Service.h"
13+
#include "FWCore/MessageLogger/interface/MessageLogger.h"
14+
#include "FWCore/ParameterSet/interface/ParameterSet.h"
15+
#include "CalibFormats/SiStripObjects/interface/SiStripQuality.h"
16+
#include "CalibTracker/Records/interface/SiStripQualityRcd.h"
17+
18+
class testSiStripQualityESProducer : public edm::one::EDAnalyzer<> {
19+
public:
20+
explicit testSiStripQualityESProducer(const edm::ParameterSet&);
21+
~testSiStripQualityESProducer() = default;
22+
23+
void analyze(const edm::Event&, const edm::EventSetup&);
24+
25+
private:
26+
void printObject(const SiStripQuality*);
27+
28+
const edm::ESGetToken<SiStripQuality, SiStripQualityRcd> qualityToken_;
29+
const edm::ESGetToken<SiStripQuality, SiStripQualityRcd> qualityTokenTwo_;
30+
bool printdebug_;
31+
unsigned long long m_cacheID_;
32+
bool firstIOV;
33+
bool twoRecordComparison_;
34+
SiStripQuality* m_Quality_;
35+
};
36+
1137
testSiStripQualityESProducer::testSiStripQualityESProducer(const edm::ParameterSet& iConfig)
12-
: printdebug_(iConfig.getUntrackedParameter<bool>("printDebug", false)),
38+
: qualityToken_(esConsumes(edm::ESInputTag("", iConfig.getUntrackedParameter<std::string>("dataLabel", "")))),
39+
qualityTokenTwo_(esConsumes(edm::ESInputTag("", iConfig.getUntrackedParameter<std::string>("dataLabelTwo", "")))),
40+
printdebug_(iConfig.getUntrackedParameter<bool>("printDebug", false)),
1341
m_cacheID_(0),
1442
firstIOV(true),
15-
twoRecordComparison_(iConfig.getUntrackedParameter<bool>("twoRecordComparison", false)),
16-
dataLabel_(iConfig.getUntrackedParameter<std::string>("dataLabel", "")),
17-
dataLabelTwo_(iConfig.getUntrackedParameter<std::string>("dataLabelTwo", "")) {}
43+
twoRecordComparison_(iConfig.getUntrackedParameter<bool>("twoRecordComparison", false)) {}
1844

1945
void testSiStripQualityESProducer::analyze(const edm::Event& e, const edm::EventSetup& iSetup) {
2046
unsigned long long cacheID = iSetup.get<SiStripQualityRcd>().cacheIdentifier();
@@ -29,8 +55,7 @@ void testSiStripQualityESProducer::analyze(const edm::Event& e, const edm::Event
2955
//&&&&&&&&&&&&&&&&&&
3056
//First Record
3157
//&&&&&&&&&&&&&&&&&&
32-
edm::ESHandle<SiStripQuality> SiStripQualityESH_;
33-
iSetup.get<SiStripQualityRcd>().get(dataLabel_, SiStripQualityESH_);
58+
edm::ESHandle<SiStripQuality> SiStripQualityESH_ = iSetup.getHandle(qualityToken_);
3459
edm::LogInfo("testSiStripQualityESProducer")
3560
<< canvas << "[testSiStripQualityESProducer::analyze] Print SiStripQualityRecord" << canvas << std::endl;
3661
printObject(SiStripQualityESH_.product());
@@ -40,7 +65,7 @@ void testSiStripQualityESProducer::analyze(const edm::Event& e, const edm::Event
4065
//&&&&&&&&&&&&&&&&&&
4166
edm::ESHandle<SiStripQuality> twoSiStripQualityESH_;
4267
if (twoRecordComparison_) {
43-
iSetup.get<SiStripQualityRcd>().get(dataLabelTwo_, twoSiStripQualityESH_);
68+
twoSiStripQualityESH_ = iSetup.getHandle(qualityTokenTwo_);
4469
edm::LogInfo("testSiStripQualityESProducer")
4570
<< canvas << "[testSiStripQualityESProducer::analyze] Print Second SiStripQualityRecord" << canvas << std::endl;
4671
printObject(twoSiStripQualityESH_.product());
@@ -128,3 +153,8 @@ void testSiStripQualityESProducer::printObject(const SiStripQuality* SiStripQual
128153

129154
edm::LogInfo("testSiStripQualityESProducer") << ss.str();
130155
}
156+
157+
#include "FWCore/PluginManager/interface/ModuleDef.h"
158+
#include "FWCore/Framework/interface/MakerMacros.h"
159+
160+
DEFINE_FWK_MODULE(testSiStripQualityESProducer);

CalibTracker/SiStripESProducers/test/testSiStripQualityESProducer.h

-35
This file was deleted.

0 commit comments

Comments
 (0)