Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Rebase repo in E2E GH action #492

Open
nabuskey opened this issue Feb 21, 2025 · 0 comments
Open

[Bug]: Rebase repo in E2E GH action #492

nabuskey opened this issue Feb 21, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@nabuskey
Copy link
Collaborator

What is your environment, configuration, and command?

In here:

e2e-slash-command:
runs-on: ubuntu-22.04
if: ${{ github.event.action == 'e2e-command' }}
steps:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
with:
repository: ${{ github.event.client_payload.pull_request.head.repo.full_name }}
ref: ${{ github.event.client_payload.pull_request.head.ref }}
fetch-depth: 0
- name: Setup Go
uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1
with:
go-version: '1.22'
- name: Run tests
run: |
make e2e

We only checkout the PR branch and run e2e against that. We need to rebase, then run to give us a better assurance that it actually works once merged.

What did you do and What did you see instead?

NA

Additional Information. Logs.

No response

@nabuskey nabuskey added the bug Something isn't working label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant