Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cronjob to circle ci pipeline [TAROT-2376] #2

Merged
merged 3 commits into from
Oct 11, 2023
Merged

feat: add cronjob to circle ci pipeline [TAROT-2376] #2

merged 3 commits into from
Oct 11, 2023

Conversation

Afonsobli
Copy link
Contributor

No description provided.

@Afonsobli Afonsobli force-pushed the feat/TAROT-2376 branch 30 times, most recently from 286760b to 7988ae9 Compare October 9, 2023 09:22
afsmeira
afsmeira approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@afsmeira afsmeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did the scheduled workflow already run?

afsmeira
afsmeira requested changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@afsmeira afsmeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, you need to change the Dockerfile to copy the cache folder inside the image.

@Afonsobli
Copy link
Contributor Author

LGTM. Did the scheduled workflow already run?

it did!

@Afonsobli Afonsobli force-pushed the feat/TAROT-2376 branch 11 times, most recently from 227b368 to e6ffa59 Compare October 11, 2023 11:18
afsmeira
afsmeira reviewed Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@afsmeira afsmeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to add a cache entry in .gitignore.

Dockerfile Outdated Show resolved Hide resolved
@Afonsobli Afonsobli force-pushed the feat/TAROT-2376 branch 6 times, most recently from 3d64839 to 8ac33bf Compare October 11, 2023 12:30
afsmeira
afsmeira previously approved these changes Oct 11, 2023
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@Afonsobli Afonsobli merged commit 858e4e3 into master Oct 11, 2023
1 check passed
@Afonsobli Afonsobli deleted the feat/TAROT-2376 branch October 11, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afsmeira afsmeira afsmeira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Afonsobli @afsmeira