Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defaultValueStrategy to InstructionAccountNode? #81

Open
lorisleiva opened this issue Jun 19, 2024 · 0 comments
Open

Add defaultValueStrategy to InstructionAccountNode? #81

lorisleiva opened this issue Jun 19, 2024 · 0 comments
Labels
proposal Suggesting a change / new feature

Comments

@lorisleiva
Copy link
Member

Currently, InstructionArgumentNodes have a defaultValue attribute as well as a defaultValueStrategy attribute which can either be "omitted" or "optional". This means, we can decide if the default value should be overridable by the end user or if, really, this default value should never be altered.

Since InstructionAccountNodes also have a defaultValue attribute, would it make sense for them to also have the same defaultValueStrategy attribute? and "omitted" strategy would then let the renderers know that the account shouldn't even be present in the input of the instruction helper.

@lorisleiva lorisleiva added the proposal Suggesting a change / new feature label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Suggesting a change / new feature
Projects
None yet
Development

No branches or pull requests

1 participant