Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #424

Open
code423n4 opened this issue May 4, 2023 · 6 comments
Open

QA Report #424

code423n4 opened this issue May 4, 2023 · 6 comments
Labels
bug Something isn't working grade-a high quality report This report is of especially high quality Q-04 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

See the markdown file with the details of this report here.
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels May 4, 2023
code423n4 added a commit that referenced this issue May 4, 2023
@code423n4
Cyfrin issue #424
4784a59
code423n4 added a commit that referenced this issue May 4, 2023
@code423n4
Cyfrin data for issue #424
ce4af8c
@c4-pre-sort
Copy link

0xSorryNotSorry marked the issue as high quality report

@c4-pre-sort c4-pre-sort added the high quality report This report is of especially high quality label May 9, 2023
@GalloDaSballo
Copy link

[L-01] Endian::fromLittleEndianUint64 allows unsafe casting
R, similar to adding check for bytes%32 in merkle functions

[NC-01] EigenPod::stake: should be refactored to allow any stake and not just 32 ether
R, I can see scenarios in which this would useful (e.g. getting slashed and wanting to top up)

[NC-02] Rename EigenPod::mostRecentWithdrawalBlockNumber to mostRecentWithdrawalBeforeRestakingBlockNumber
R

@GalloDaSballo
Copy link

3R unique report

@c4-judge
Copy link
Contributor

c4-judge commented Jun 2, 2023

GalloDaSballo marked the issue as grade-b

@GalloDaSballo
Copy link

A after adding DUPS

@c4-judge
Copy link
Contributor

c4-judge commented Jun 8, 2023

GalloDaSballo marked the issue as grade-a

@c4-judge c4-judge added grade-a and removed grade-b labels Jun 8, 2023
@C4-Staff C4-Staff added the Q-04 label Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working grade-a high quality report This report is of especially high quality Q-04 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@GalloDaSballo @code423n4 @c4-judge @c4-pre-sort @C4-Staff