Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: auth guard reactive user detection #92

Closed
wants to merge 1 commit into from
Closed

Fix: auth guard reactive user detection #92

wants to merge 1 commit into from

Conversation

jornetsimon
Copy link

Fixes #87

@miiiguel
Copy link

miiiguel commented Dec 5, 2020

Hi, man!

Thank you for this fix. I understand how this solution works, however; I'm still wondering why it wasn't working before as a promise.

I mean, the promise returns whether or not the user is logged when changing between routes just fine, but it doesn't when refreshing. I know promises are one-time values, whereas observables are streams of data.

Does it have to do with the fact that the promise has been resolved before and hence the value is lost when refreshing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth Guard not working correctly on page refresh
2 participants