Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit install to make up #1222

Open
KentShikama opened this issue Jun 11, 2020 · 1 comment
Open

Add pre-commit install to make up #1222

KentShikama opened this issue Jun 11, 2020 · 1 comment
Assignees
Labels

Comments

@KentShikama
Copy link
Member

This may involve documenting how to install pre-commit.

@jerrywardlow
Copy link

Hi Kent, I've got a draft for the necessary changes to the Makefile, though I'm curious your thoughts on documentation. Currently this project states that it relies only on Docker and Docker Compose with no other native dependencies required. Including pre-commit is obviously an addition to this and I'm wondering how best to update the README. I'm thinking something like the following might work, though again would love to get an opinion on the overall voice and approach here.

Our dev environment is entirely containerized with Docker, with minimal native dependencies required.

The actual installation instructions should be trivial, thanks in advance for input on the above though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants