Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Regression: Missing "select all" in context menu #1451

Open
personalizedrefrigerator opened this issue Oct 6, 2024 · 2 comments
Open

Comments

@personalizedrefrigerator
Copy link

personalizedrefrigerator commented Oct 6, 2024

Describe the issue

Summary

In Android, the "select all" long-press menu option is missing.

Current behavior (codemirror/view v6.34.1)

select-all-broken.webm

Previous behavior (codemirror/view v6.27.0, codemirror/autocomplete v6.13.0

select-all-working.webm

To reproduce

  1. Run the "Minimal editor" example.
  2. Move the cursor to after the "...".
  3. Type text and select it.
  4. Observe that "select all" is not present in the context menu.
  5. Repeat steps 3-4 for the "code" tab.

Notes

  • After switching to a working version of @codemirror/view, refreshing the page doesn't seem to be enough to get "select all" to work. Instead, it seems to be necessary to open the demo page in a new tab.
  • A git bisect suggests that this issue was introduced with 51d20b6bde168685f303e5993d79e396b4873f65.

Browser and platform

Android 13; Chrome Android 128.0.6613.148

Reproduction link

https://codemirror.net/try/

@personalizedrefrigerator personalizedrefrigerator changed the title Android: Missing "select all" in context menu Android: Regression: Missing "select all" in context menu Oct 6, 2024
@marijnh
Copy link
Member

marijnh commented Oct 7, 2024

Chrome appears to disable this menu item when the EditContext API is used. This doesn't seem like reasonable behavior, so I've opened issue 371791303 to report it.

@josephrocca
Copy link

josephrocca commented Nov 30, 2024

In case anyone else runs into this issue, note that delete window.EditContext; before initializing CodeMirror is a hacky workaround for now.

(If this is an exceptionally dumb approach, hopefully Cunningham's Law will elicit a better one below this comment ^^', but I'm assuming that this issue won't be around for long, so I figured a hacky approach will do.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants