Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve connection before sync #920

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kornelione
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Merging #920 (c27ef46) into master (3cce5b1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #920   +/-   ##
=======================================
  Coverage   81.01%   81.01%           
=======================================
  Files          46       46           
  Lines        3050     3050           
  Branches      119      119           
=======================================
  Hits         2471     2471           
  Misses        579      579           
Files Coverage Δ
...rc/main/scala/cognite/spark/v1/DefaultSource.scala 91.22% <ø> (ø)

Copy link
Contributor

@thorkildcognite thorkildcognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is this specific issue, but it is a valid point that it may match the wrong one first.

But, I think it also means that we do not support sync on cdf_data_models-with-connection-type relation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants