Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releasing a version is way too complex #1030

Open
andersfylling opened this issue Oct 10, 2023 · 1 comment
Open

Releasing a version is way too complex #1030

andersfylling opened this issue Oct 10, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@andersfylling
Copy link
Contributor

andersfylling commented Oct 10, 2023

Describe the bug
When I do a squash commit and write "BREAKING CHANGES" in the footer, I expect that it's going to be a major release. Not minor, and not patch as well. Just major.

When I do a minor release, by typing "feat:" in the commit title, I expect there to be only a minor release, no patch releases.

It would be great to see that a release version is carried out across all affected packages. Think WYSIWYG principle. It's better to have multiple smaller PR's, if granularity is a concern, than trying to have a smart system that consistently deploys incorrect versions which may cause dependents to have a bad day.

Suggested change:

  • commit title feat!: msg causes a major release in all affected packages
  • commit title feat: msg causes a minor release in all affected packages
  • commit title fix: msg causes a patch release in all affected packages
  • drop requirement to have BREAKING CHANGES: msg in the footer, and keep release logic consistent and unified.

related:

@andersfylling andersfylling added the bug Something isn't working label Oct 10, 2023
@RodrigoRVSN
Copy link

Just to put as a reference/example, release-please works in this way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants