Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(document content): support external id and instance id #2046

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

andersfylling
Copy link

@andersfylling andersfylling commented Nov 24, 2024

We recently deprecated the GET variant in favor of a POST variant as we plan to extend the request options in the future.

@andersfylling andersfylling changed the title anders/documents status feat(document content): support external id and instance id Nov 24, 2024
The GET variant was deprecated in favor of having a request body to handle different arguments.
@andersfylling andersfylling force-pushed the anders/documents-status branch from e533c89 to 1c41faa Compare November 24, 2024 09:43
@andersfylling andersfylling marked this pull request as ready for review November 24, 2024 09:49
@andersfylling andersfylling requested review from a team as code owners November 24, 2024 09:49
This reverts commit b21c8c6.
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.46%. Comparing base (297b56e) to head (bb38f03).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2046   +/-   ##
=======================================
  Coverage   90.46%   90.46%           
=======================================
  Files         139      139           
  Lines       22393    22399    +6     
=======================================
+ Hits        20257    20263    +6     
  Misses       2136     2136           
Files with missing lines Coverage Δ
cognite/client/_api/documents.py 78.22% <100.00%> (+1.10%) ⬆️
cognite/client/_version.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Contributor

@haakonvt haakonvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This reverts commit f231915.
@andersfylling andersfylling added auto-update Will automatically keep PR up to date auto-merge labels Nov 24, 2024
@andersfylling andersfylling removed auto-update Will automatically keep PR up to date auto-merge labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants