-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(document content): support external id and instance id #2046
Open
andersfylling
wants to merge
8
commits into
master
Choose a base branch
from
anders/documents-status
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersfylling
changed the title
anders/documents status
feat(document content): support external id and instance id
Nov 24, 2024
The GET variant was deprecated in favor of having a request body to handle different arguments.
andersfylling
force-pushed
the
anders/documents-status
branch
from
November 24, 2024 09:43
e533c89
to
1c41faa
Compare
This reverts commit b21c8c6.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2046 +/- ##
=======================================
Coverage 90.46% 90.46%
=======================================
Files 139 139
Lines 22393 22399 +6
=======================================
+ Hits 20257 20263 +6
Misses 2136 2136
|
haakonvt
approved these changes
Nov 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit f231915.
andersfylling
added
auto-update
Will automatically keep PR up to date
auto-merge
labels
Nov 24, 2024
andersfylling
removed
auto-update
Will automatically keep PR up to date
auto-merge
labels
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently deprecated the GET variant in favor of a POST variant as we plan to extend the request options in the future.