Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not call setState on unmounted DataProvider component #115

Open
valgussev opened this issue Jul 25, 2018 · 0 comments
Open

Do not call setState on unmounted DataProvider component #115

valgussev opened this issue Jul 25, 2018 · 0 comments
Labels
backlog bug Something isn't working

Comments

@valgussev
Copy link
Contributor

We have the following warning on griff unmount stage

Warning: Can't call setState (or forceUpdate) on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.

This is basically because we mix async await logic and setState in DataProvider.
@valgussev valgussev added the bug Something isn't working label Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rj126 @valgussev